| Message ID | 20210607113840.15435-4-bhupesh.sharma@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: Add SA8155p-adp board DTS | expand |
On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > SA8155p-adp board is based on Qualcomm Snapdragon sm8150 > SoC. > > Add support for the same. The SA8155p is similar to SM8150 and we can reuse most things, but I think we can afford to add qcom,sa8155p in the DT bindings. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: bhupesh.linux@gmail.com > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 9b27e991bddc..b5897f1f9695 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -42,11 +42,13 @@ description: | > sdm660 > sdm845 > sdx55 > + sm8150 Naturally sm8150 should be part of this list, but please also add sa8155p as well. > sm8250 > sm8350 > > The 'board' element must be one of the following strings: > > + adp > cdp > cp01-c1 > dragonboard > @@ -198,6 +200,12 @@ properties: > - qcom,ipq6018-cp01-c1 > - const: qcom,ipq6018 > > + - items: > + - enum: > + - qcom,sa8155p-adp > + - qcom,sm8150-mtp > + - const: qcom,sm8150 And please split this in two (one qcom,sm8150-mtp and qcom,sm8150, and one qcom,sa8155p-adp and qcom,sa8155p). And note that this is saying that your compatible needs to be one of the enum entries, followed by the const, but in your dts you only specified qcom,sa8155p-adp. It needs to be: compatible = "qcom,sa8155p-adp", "qcom,sa8155p"; Thanks, Bjorn > + > - items: > - enum: > - qcom,qrb5165-rb5 > -- > 2.31.1 >
Hello Bjorn, On Fri, 11 Jun 2021 at 08:29, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > > > SA8155p-adp board is based on Qualcomm Snapdragon sm8150 > > SoC. > > > > Add support for the same. > > The SA8155p is similar to SM8150 and we can reuse most things, but I > think we can afford to add qcom,sa8155p in the DT bindings. Sure will do the same in v2. > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Andy Gross <agross@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-gpio@vger.kernel.org > > Cc: bhupesh.linux@gmail.com > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > > index 9b27e991bddc..b5897f1f9695 100644 > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > > @@ -42,11 +42,13 @@ description: | > > sdm660 > > sdm845 > > sdx55 > > + sm8150 > > Naturally sm8150 should be part of this list, but please also add > sa8155p as well. Ok. > > sm8250 > > sm8350 > > > > The 'board' element must be one of the following strings: > > > > + adp > > cdp > > cp01-c1 > > dragonboard > > @@ -198,6 +200,12 @@ properties: > > - qcom,ipq6018-cp01-c1 > > - const: qcom,ipq6018 > > > > + - items: > > + - enum: > > + - qcom,sa8155p-adp > > + - qcom,sm8150-mtp > > + - const: qcom,sm8150 > > And please split this in two (one qcom,sm8150-mtp and qcom,sm8150, and > one qcom,sa8155p-adp and qcom,sa8155p). > > And note that this is saying that your compatible needs to be one of the > enum entries, followed by the const, but in your dts you only specified > qcom,sa8155p-adp. It needs to be: > > compatible = "qcom,sa8155p-adp", "qcom,sa8155p"; Sure will do the same in v2. Regards, Bhupesh > > + > > - items: > > - enum: > > - qcom,qrb5165-rb5 > > -- > > 2.31.1 > >
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 9b27e991bddc..b5897f1f9695 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -42,11 +42,13 @@ description: | sdm660 sdm845 sdx55 + sm8150 sm8250 sm8350 The 'board' element must be one of the following strings: + adp cdp cp01-c1 dragonboard @@ -198,6 +200,12 @@ properties: - qcom,ipq6018-cp01-c1 - const: qcom,ipq6018 + - items: + - enum: + - qcom,sa8155p-adp + - qcom,sm8150-mtp + - const: qcom,sm8150 + - items: - enum: - qcom,qrb5165-rb5
SA8155p-adp board is based on Qualcomm Snapdragon sm8150 SoC. Add support for the same. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Andy Gross <agross@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: bhupesh.linux@gmail.com Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)