| Message ID | 20210623021303.28015-1-cl@rock-chips.com |
|---|---|
| State | Accepted |
| Commit | dd8f6b299a2b86c4839de4a60a28ce2399453bc0 |
| Headers | show |
| Series | [RESEND,v5,1/4] dt-bindings: pwm: rockchip: add description for rk3568 | expand |
On Wed, Jun 23, 2021 at 10:13:03AM +0800, cl@rock-chips.com wrote: > From: Liang Chen <cl@rock-chips.com> > > add "rockchip,rk3568-pwm", "rockchip,rk3328-pwm" for pwm nodes on > a rk3568 platform to pwm-rockchip.yaml. Looks good to me Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Who is supposed to apply this patch? Does this need blessing by Rob? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
On Mon, 05 Jul 2021, Uwe Kleine-König wrote: > On Wed, Jun 23, 2021 at 10:13:03AM +0800, cl@rock-chips.com wrote: > > From: Liang Chen <cl@rock-chips.com> > > > > add "rockchip,rk3568-pwm", "rockchip,rk3328-pwm" for pwm nodes on > > a rk3568 platform to pwm-rockchip.yaml. > > Looks good to me > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Who is supposed to apply this patch? Does this need blessing by Rob? There is no standard. Rob will usually have some kind of arrangement with the associated maintainer(s). If this is a big functional change, I would suggest letting Rob and his army of bots give it the once over before it is applied in any case.
Hello Lee, On Mon, Jul 05, 2021 at 08:34:18AM +0100, Lee Jones wrote: > On Mon, 05 Jul 2021, Uwe Kleine-König wrote: > > On Wed, Jun 23, 2021 at 10:13:03AM +0800, cl@rock-chips.com wrote: > > > From: Liang Chen <cl@rock-chips.com> > > > > > > add "rockchip,rk3568-pwm", "rockchip,rk3328-pwm" for pwm nodes on > > > a rk3568 platform to pwm-rockchip.yaml. > > > > [...] > > > > Who is supposed to apply this patch? Does this need blessing by Rob? > > There is no standard. [...] I'm aware of that. That's why I asked to prevent that everybody thinks some other maintainer will care for it. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Am Montag, 5. Juli 2021, 09:44:05 CEST schrieb Uwe Kleine-König: > Hello Lee, > > On Mon, Jul 05, 2021 at 08:34:18AM +0100, Lee Jones wrote: > > On Mon, 05 Jul 2021, Uwe Kleine-König wrote: > > > On Wed, Jun 23, 2021 at 10:13:03AM +0800, cl@rock-chips.com wrote: > > > > From: Liang Chen <cl@rock-chips.com> > > > > > > > > add "rockchip,rk3568-pwm", "rockchip,rk3328-pwm" for pwm nodes on > > > > a rk3568 platform to pwm-rockchip.yaml. > > > > > > [...] > > > > > > Who is supposed to apply this patch? Does this need blessing by Rob? > > > > There is no standard. [...] > > I'm aware of that. That's why I asked to prevent that everybody thinks > some other maintainer will care for it. I suppose Thierry would be the one responsible? I.e. bindings normally go through the subsystem tree and $ scripts/get_maintainer.pl drivers/pwm returns: Thierry Reding <thierry.reding@gmail.com> (maintainer:PWM SUBSYSTEM) "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> (reviewer:PWM SUBSYSTEM) Lee Jones <lee.jones@linaro.org> (maintainer:PWM SUBSYSTEM) linux-pwm@vger.kernel.org (open list:PWM SUBSYSTEM) linux-kernel@vger.kernel.org (open list) See my reply to the original pwm binding patch from 2021-06-21. Heiko
On Mon, Jul 05, 2021 at 08:34:18AM +0100, Lee Jones wrote: > On Mon, 05 Jul 2021, Uwe Kleine-König wrote: > > > On Wed, Jun 23, 2021 at 10:13:03AM +0800, cl@rock-chips.com wrote: > > > From: Liang Chen <cl@rock-chips.com> > > > > > > add "rockchip,rk3568-pwm", "rockchip,rk3328-pwm" for pwm nodes on > > > a rk3568 platform to pwm-rockchip.yaml. > > > > Looks good to me > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > Who is supposed to apply this patch? Does this need blessing by Rob? > > There is no standard. Rob will usually have some kind of arrangement > with the associated maintainer(s). If this is a big functional > change, I would suggest letting Rob and his army of bots give it the > once over before it is applied in any case. The documented standard[1] is subsystem maintainers take bindings. Are there exceptions? Yes. Usually that's standalone patches (which netdev maintainers just ignore for example). One line compatible string changes don't need to wait for me. Rob [1] https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/submitting-patches.rst#n67
On Wed, 23 Jun 2021 10:13:03 +0800, cl@rock-chips.com wrote: > From: Liang Chen <cl@rock-chips.com> > > add "rockchip,rk3568-pwm", "rockchip,rk3328-pwm" for pwm nodes on > a rk3568 platform to pwm-rockchip.yaml. > > Signed-off-by: Liang Chen <cl@rock-chips.com> > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml index 5596bee70509..81a54a4e8e3e 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml @@ -29,6 +29,7 @@ properties: - enum: - rockchip,px30-pwm - rockchip,rk3308-pwm + - rockchip,rk3568-pwm - const: rockchip,rk3328-pwm reg: