| Message ID | 20210706230702.299047-2-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node | expand |
On Tue 06 Jul 18:07 CDT 2021, Bryan O'Donoghue wrote: > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to > fix issues with TypeC support. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes") > Cc: robh+dt@kernel.org > Cc: devicetree@vger.kernel.org > Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 4c0de12aaba6..270d7ff59ec1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 { > <&gcc GCC_USB3_PHY_SEC_BCR>; > reset-names = "phy", "common"; > > - usb_2_ssphy: lane@88eb200 { > + usb_2_ssphy: lanes@88eb200 { The uni-phy binding says that this should be named "^phy@[0-9a-f]+$" So while Dmitry is right about the logic in the driver, it would be nice if you would spin this patch to make us pass the dt-binding check - which can be sent independently from the driver patch. Regards, Bjorn > reg = <0 0x088eb200 0 0x200>, > <0 0x088eb400 0 0x200>, > <0 0x088eb800 0 0x800>; > -- > 2.30.1 >
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 4c0de12aaba6..270d7ff59ec1 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 { <&gcc GCC_USB3_PHY_SEC_BCR>; reset-names = "phy", "common"; - usb_2_ssphy: lane@88eb200 { + usb_2_ssphy: lanes@88eb200 { reg = <0 0x088eb200 0 0x200>, <0 0x088eb400 0 0x200>, <0 0x088eb800 0 0x800>;