diff mbox series

[1/6] arm: crypto: rename 'mod_init' & 'mod_exit' functions to be module-specific

Message ID 20210709021747.32737-2-rdunlap@infradead.org
State Superseded
Headers show
Series treewide: rename 'mod_init' & 'mod_exit' functions to be module-specific | expand

Commit Message

Randy Dunlap July 9, 2021, 2:17 a.m. UTC 
Rename module_init & module_exit functions that are named
"mod_init" and "mod_exit" so that they are unique in both the
System.map file and in initcall_debug output instead of showing
up as almost anonymous "mod_init".

This is helpful for debugging and in determining how long certain
module_init calls take to execute.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: patches@armlinux.org.uk
---
 arch/arm/crypto/curve25519-glue.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Russell King (Oracle) July 9, 2021, 9:59 a.m. UTC | #1 
On Thu, Jul 08, 2021 at 07:17:42PM -0700, Randy Dunlap wrote:
> Rename module_init & module_exit functions that are named
> "mod_init" and "mod_exit" so that they are unique in both the
> System.map file and in initcall_debug output instead of showing
> up as almost anonymous "mod_init".
> 
> This is helpful for debugging and in determining how long certain
> module_init calls take to execute.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: linux-arm-kernel@lists.infradead.org

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
diff mbox series

Patch

--- linux-next-20210708.orig/arch/arm/crypto/curve25519-glue.c
+++ linux-next-20210708/arch/arm/crypto/curve25519-glue.c
@@ -112,7 +112,7 @@  static struct kpp_alg curve25519_alg = {
 	.max_size		= curve25519_max_size,
 };
 
-static int __init mod_init(void)
+static int __init arm_curve25519_init(void)
 {
 	if (elf_hwcap & HWCAP_NEON) {
 		static_branch_enable(&have_neon);
@@ -122,14 +122,14 @@  static int __init mod_init(void)
 	return 0;
 }
 
-static void __exit mod_exit(void)
+static void __exit arm_curve25519_exit(void)
 {
 	if (IS_REACHABLE(CONFIG_CRYPTO_KPP) && elf_hwcap & HWCAP_NEON)
 		crypto_unregister_kpp(&curve25519_alg);
 }
 
-module_init(mod_init);
-module_exit(mod_exit);
+module_init(arm_curve25519_init);
+module_exit(arm_curve25519_exit);
 
 MODULE_ALIAS_CRYPTO("curve25519");
 MODULE_ALIAS_CRYPTO("curve25519-neon");