diff mbox series

powerpc/fsl/dts: Fix phy-connection-type for fm1mac3

Message ID 20210704134325.24842-1-pali@kernel.org
State New
Headers show
Series powerpc/fsl/dts: Fix phy-connection-type for fm1mac3 | expand

Commit Message

Pali Rohár July 4, 2021, 1:43 p.m. UTC
Property phy-connection-type contains invalid value "sgmii-2500" per scheme
defined in file ethernet-controller.yaml.

Correct phy-connection-type value should be "2500base-x".

Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the board device tree(s)")
---
 arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Scott Wood July 14, 2021, 5:11 p.m. UTC | #1
On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote:
> Property phy-connection-type contains invalid value "sgmii-2500" per scheme
> defined in file ethernet-controller.yaml.
> 
> Correct phy-connection-type value should be "2500base-x".
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the
> board device tree(s)")
> ---
>  arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> index 5ba6fbfca274..f82f85c65964 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> @@ -154,7 +154,7 @@
>  
>                         fm1mac3: ethernet@e4000 {
>                                 phy-handle = <&sgmii_aqr_phy3>;
> -                               phy-connection-type = "sgmii-2500";
> +                               phy-connection-type = "2500base-x";
>                                 sleep = <&rcpm 0x20000000>;
>                         };
>  

Acked-by: Scott Wood <oss@buserror.net>

-Scott
Pali Rohár Aug. 27, 2021, 11:38 a.m. UTC | #2
On Wednesday 14 July 2021 12:11:49 Scott Wood wrote:
> On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote:
> > Property phy-connection-type contains invalid value "sgmii-2500" per scheme
> > defined in file ethernet-controller.yaml.
> > 
> > Correct phy-connection-type value should be "2500base-x".
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the
> > board device tree(s)")
> > ---
> >  arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > index 5ba6fbfca274..f82f85c65964 100644
> > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > @@ -154,7 +154,7 @@
> >  
> >                         fm1mac3: ethernet@e4000 {
> >                                 phy-handle = <&sgmii_aqr_phy3>;
> > -                               phy-connection-type = "sgmii-2500";
> > +                               phy-connection-type = "2500base-x";
> >                                 sleep = <&rcpm 0x20000000>;
> >                         };
> >  
> 
> Acked-by: Scott Wood <oss@buserror.net>
> 
> -Scott

Hello! If there is not any objection, could you take this patch?
diff mbox series

Patch

diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
index 5ba6fbfca274..f82f85c65964 100644
--- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
@@ -154,7 +154,7 @@ 
 
 			fm1mac3: ethernet@e4000 {
 				phy-handle = <&sgmii_aqr_phy3>;
-				phy-connection-type = "sgmii-2500";
+				phy-connection-type = "2500base-x";
 				sleep = <&rcpm 0x20000000>;
 			};