| Message ID | 20210812093356.1946-5-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm: Get rid of system_clock_scale global | expand |
On Thu, Aug 12, 2021 at 7:34 PM Peter Maydell <peter.maydell@linaro.org> wrote: > > Add the usual-style QEMU interface comment documenting what > properties, etc, this device exposes. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > include/hw/timer/armv7m_systick.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/hw/timer/armv7m_systick.h b/include/hw/timer/armv7m_systick.h > index 84496faaf96..685fc5bc0d7 100644 > --- a/include/hw/timer/armv7m_systick.h > +++ b/include/hw/timer/armv7m_systick.h > @@ -20,6 +20,13 @@ > > OBJECT_DECLARE_SIMPLE_TYPE(SysTickState, SYSTICK) > > +/* > + * QEMU interface: > + * + sysbus MMIO region 0 is the register interface (covering > + * the registers which are mapped at address 0xE000E010) > + * + sysbus IRQ 0 is the interrupt line to the NVIC > + */ > + > struct SysTickState { > /*< private >*/ > SysBusDevice parent_obj; > -- > 2.20.1 > >
On 10:33 Thu 12 Aug , Peter Maydell wrote: > Add the usual-style QEMU interface comment documenting what > properties, etc, this device exposes. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Luc Michel <luc@lmichel.fr> > --- > include/hw/timer/armv7m_systick.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/hw/timer/armv7m_systick.h b/include/hw/timer/armv7m_systick.h > index 84496faaf96..685fc5bc0d7 100644 > --- a/include/hw/timer/armv7m_systick.h > +++ b/include/hw/timer/armv7m_systick.h > @@ -20,6 +20,13 @@ > > OBJECT_DECLARE_SIMPLE_TYPE(SysTickState, SYSTICK) > > +/* > + * QEMU interface: > + * + sysbus MMIO region 0 is the register interface (covering > + * the registers which are mapped at address 0xE000E010) > + * + sysbus IRQ 0 is the interrupt line to the NVIC > + */ > + > struct SysTickState { > /*< private >*/ > SysBusDevice parent_obj; > -- > 2.20.1 > --
diff --git a/include/hw/timer/armv7m_systick.h b/include/hw/timer/armv7m_systick.h index 84496faaf96..685fc5bc0d7 100644 --- a/include/hw/timer/armv7m_systick.h +++ b/include/hw/timer/armv7m_systick.h @@ -20,6 +20,13 @@ OBJECT_DECLARE_SIMPLE_TYPE(SysTickState, SYSTICK) +/* + * QEMU interface: + * + sysbus MMIO region 0 is the register interface (covering + * the registers which are mapped at address 0xE000E010) + * + sysbus IRQ 0 is the interrupt line to the NVIC + */ + struct SysTickState { /*< private >*/ SysBusDevice parent_obj;
Add the usual-style QEMU interface comment documenting what properties, etc, this device exposes. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- include/hw/timer/armv7m_systick.h | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.20.1