diff mbox series

[next] octeontx2-af: remove redudant second error check on variable err

Message ID 20210818130927.33895-1-colin.king@canonical.com
State New
Headers show
Series [next] octeontx2-af: remove redudant second error check on variable err | expand

Commit Message

Colin King Aug. 18, 2021, 1:09 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

A recent change added error checking messages and failed to remove one
of the previous error checks. There are now two checks on variable err
so the second one is redundant dead code and can be removed.

Addresses-Coverity: ("Logically dead code")
Fixes: a83bdada06bf ("octeontx2-af: Add debug messages for failures")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 --
 1 file changed, 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 19, 2021, 7:30 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 18 Aug 2021 14:09:27 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> A recent change added error checking messages and failed to remove one
> of the previous error checks. There are now two checks on variable err
> so the second one is redundant dead code and can be removed.
> 
> Addresses-Coverity: ("Logically dead code")
> Fixes: a83bdada06bf ("octeontx2-af: Add debug messages for failures")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> [...]

Here is the summary with links:
  - [next] octeontx2-af: remove redudant second error check on variable err
    https://git.kernel.org/netdev/net-next/c/9e5f10fe577b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index fb50df93b54e..c2438ba5e2ec 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -1031,8 +1031,6 @@  static int rvu_setup_hw_resources(struct rvu *rvu)
 			"%s: Failed to allocate CPT1 LF bitmap\n", __func__);
 		return err;
 	}
-	if (err)
-		return err;
 
 	/* Allocate memory for PFVF data */
 	rvu->pf = devm_kcalloc(rvu->dev, hw->total_pfs,