| Message ID | 20210824105858.19496-1-rogerq@kernel.org |
|---|---|
| Headers | show |
| Series | ARM: dts: keystone-k2*-evm: Fix mdio and dss node status | expand |
On 24/08/2021 13:58, Roger Quadros wrote: > Hi Santosh, > > This series fixes mdio and dss status nodes from "ok" to "okay" > > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 > > cheers, > -roger > > Roger Quadros (2): > ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" > ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" > > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Changes in this version: - updated commit message to point to DT spec instead of schema.
On 13:58-20210824, Roger Quadros wrote: > Hi Santosh, > > This series fixes mdio and dss status nodes from "ok" to "okay" > > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. ^^ I suspect the above comment in the patches is to indicate side effect of non-compliance. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 > > cheers, > -roger > > Roger Quadros (2): > ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" > ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" Reviewed-by: Nishanth Menon <nm@ti.com> -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 24/08/2021 13:58, Roger Quadros wrote: > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 > > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Thank you. Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> -- Best regards, grygorii
Hi Santosh On 24/08/2021 13:58, Roger Quadros wrote: > Hi Santosh, > > This series fixes mdio and dss status nodes from "ok" to "okay" > > As per Device Tree Specification [1], the status parameter of nodes can > be "okay", "disabled", etc. "ok" is not a valid parameter. > > U-boot Driver Model does not recognize status="ok" either and treats > the node as disabled. > > [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 Could you please queue these trivial fixes for 5.15? Thanks > > cheers, > -roger > > Roger Quadros (2): > ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay" > ARM: dts: keystone-k2g-evm: Fix dss node status to "okay" > > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > cheers, -roger