diff mbox series

net: stmmac: fix off-by-one error in sanity check

Message ID 20210927135849.1595484-1-arnd@kernel.org
State New
Headers show
Series net: stmmac: fix off-by-one error in sanity check | expand

Commit Message

Arnd Bergmann Sept. 27, 2021, 1:58 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


My previous patch had an off-by-one error in the added sanity
check, the arrays are MTL_MAX_{RX,TX}_QUEUES long, so if that
index is that number, it has overflown.

The patch silenced the warning anyway because the strings could
no longer overlap with the input, but they could still overlap
with other fields.

Fixes: 3e0d5699a975 ("net: stmmac: fix gcc-10 -Wrestrict warning")
Reported-by: Russell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.29.2

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 28, 2021, 12:20 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 27 Sep 2021 15:58:29 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> My previous patch had an off-by-one error in the added sanity

> check, the arrays are MTL_MAX_{RX,TX}_QUEUES long, so if that

> index is that number, it has overflown.

> 

> The patch silenced the warning anyway because the strings could

> no longer overlap with the input, but they could still overlap

> with other fields.

> 

> [...]


Here is the summary with links:
  - net: stmmac: fix off-by-one error in sanity check
    https://git.kernel.org/netdev/net-next/c/d68c2e1d19c5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 640c0ffdff3d..fd4c6517125e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3502,7 +3502,7 @@  static int stmmac_request_irq_multi_msi(struct net_device *dev)
 
 	/* Request Rx MSI irq */
 	for (i = 0; i < priv->plat->rx_queues_to_use; i++) {
-		if (i > MTL_MAX_RX_QUEUES)
+		if (i >= MTL_MAX_RX_QUEUES)
 			break;
 		if (priv->rx_irq[i] == 0)
 			continue;
@@ -3527,7 +3527,7 @@  static int stmmac_request_irq_multi_msi(struct net_device *dev)
 
 	/* Request Tx MSI irq */
 	for (i = 0; i < priv->plat->tx_queues_to_use; i++) {
-		if (i > MTL_MAX_TX_QUEUES)
+		if (i >= MTL_MAX_TX_QUEUES)
 			break;
 		if (priv->tx_irq[i] == 0)
 			continue;