mbox series

[v2,0/3] drm/panel: Ensure DT compatibles have SPI device IDs

Message ID 20220202152352.20342-1-broonie@kernel.org
Headers show
Series drm/panel: Ensure DT compatibles have SPI device IDs | expand

Message

Mark Brown Feb. 2, 2022, 3:23 p.m. UTC 
Currently autoloading for SPI devices does not use the DT ID table, it uses
SPI modalises. Supporting OF modalises is going to be difficult if not
impractical, an attempt was made but has been reverted, so this series
adds SPI IDs where they aren't provided for a given modalias.

v2:
 - Rebase onto v5.17-rc1.

Mark Brown (3):
  drm/panel-ilitek-il9322: Add SPI ID table
  drm/panel-novotek-nt39016: Add SPI ID table
  drm/ili9486: Add SPI ID table

 drivers/gpu/drm/panel/panel-ilitek-ili9322.c  | 14 ++++++++++++++
 drivers/gpu/drm/panel/panel-novatek-nt39016.c |  8 ++++++++
 drivers/gpu/drm/tiny/ili9486.c                |  2 ++
 3 files changed, 24 insertions(+)


base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07

Comments

Javier Martinez Canillas Feb. 3, 2022, 9:47 a.m. UTC | #1 
Hello Mark,

On 2/2/22 16:23, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so this series
> adds SPI IDs where they aren't provided for a given modalias.
> 

Yes, that's only possible if all the SPI drivers are fixed first to make
sure that all have a proper OF device ID table and will report a modalias
if we change the core to report a OF modalias uevent.

And we also need to fix all the Device Trees to have a proper compatible
string "foo,bar" instead of just using "bar" and assume that the SPI core
will report a MODALIAS="spi:bar" even for OF.

I was able to change this for I2C after commit af503716ac14 ("i2c: core:
report OF style module alias for devices registered via OF)" but it was
a considerable amount of effort.

For the whole series:

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,