| Message ID | 20211228045934.1524865-1-bjorn.andersson@linaro.org |
|---|---|
| State | Accepted |
| Commit | f5408b21e356f2b57efcb3e2dbb5a344a20d11ae |
| Headers | show |
| Series | drm/msm/dp: Add DisplayPort controller for SM8350 | expand |
On Mon, 27 Dec 2021 20:59:34 -0800, Bjorn Andersson wrote: > The Qualcomm SM8350 platform comes with a single DisplayPort controller, > add support for this in the DisplayPort driver. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On 28/12/2021 07:59, Bjorn Andersson wrote: > The Qualcomm SM8350 platform comes with a single DisplayPort controller, > add support for this in the DisplayPort driver. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 5457612ab136..cd05cfd76536 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -21,6 +21,7 @@ properties: > - qcom,sc7280-edp > - qcom,sc8180x-dp > - qcom,sc8180x-edp > + - qcom,sm8350-dp > > reg: > items: > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 8d9c19dbf33e..fd0fd03f8fed 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = { > .num_descs = 2, > }; > > +static const struct msm_dp_config sm8350_dp_cfg = { > + .descs = (const struct msm_dp_desc[]) { > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort }, > + }, > + .num_descs = 1, > +}; > + > static const struct of_device_id dp_dt_match[] = { > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg }, > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg }, > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg }, > {} > }; >
On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote: > On 28/12/2021 07:59, Bjorn Andersson wrote: > > The Qualcomm SM8350 platform comes with a single DisplayPort controller, > > add support for this in the DisplayPort driver. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > I don't see this in linux-next, would it be possible to pick it up now that we're past the merge window etc? Regards, Bjorn > > --- > > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 + > > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index 5457612ab136..cd05cfd76536 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -21,6 +21,7 @@ properties: > > - qcom,sc7280-edp > > - qcom,sc8180x-dp > > - qcom,sc8180x-edp > > + - qcom,sm8350-dp > > reg: > > items: > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > > index 8d9c19dbf33e..fd0fd03f8fed 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_display.c > > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = { > > .num_descs = 2, > > }; > > +static const struct msm_dp_config sm8350_dp_cfg = { > > + .descs = (const struct msm_dp_desc[]) { > > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort }, > > + }, > > + .num_descs = 1, > > +}; > > + > > static const struct of_device_id dp_dt_match[] = { > > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, > > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg }, > > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg }, > > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg }, > > {} > > }; > > > -- > With best wishes > Dmitry
On Wed, 9 Feb 2022 at 00:21, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote: > > > On 28/12/2021 07:59, Bjorn Andersson wrote: > > > The Qualcomm SM8350 platform comes with a single DisplayPort controller, > > > add support for this in the DisplayPort driver. > > > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > I don't see this in linux-next, would it be possible to pick it up now > that we're past the merge window etc? I'll work on my staging tree (and send it to Rob) before the EoW. > > Regards, > Bjorn > > > > --- > > > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 + > > > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++ > > > 2 files changed, 9 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > index 5457612ab136..cd05cfd76536 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > @@ -21,6 +21,7 @@ properties: > > > - qcom,sc7280-edp > > > - qcom,sc8180x-dp > > > - qcom,sc8180x-edp > > > + - qcom,sm8350-dp > > > reg: > > > items: > > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > > > index 8d9c19dbf33e..fd0fd03f8fed 100644 > > > --- a/drivers/gpu/drm/msm/dp/dp_display.c > > > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > > > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = { > > > .num_descs = 2, > > > }; > > > +static const struct msm_dp_config sm8350_dp_cfg = { > > > + .descs = (const struct msm_dp_desc[]) { > > > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort }, > > > + }, > > > + .num_descs = 1, > > > +}; > > > + > > > static const struct of_device_id dp_dt_match[] = { > > > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, > > > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg }, > > > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg }, > > > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg }, > > > {} > > > }; > > > > > > -- > > With best wishes > > Dmitry
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 5457612ab136..cd05cfd76536 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -21,6 +21,7 @@ properties: - qcom,sc7280-edp - qcom,sc8180x-dp - qcom,sc8180x-edp + - qcom,sm8350-dp reg: items: diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 8d9c19dbf33e..fd0fd03f8fed 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = { .num_descs = 2, }; +static const struct msm_dp_config sm8350_dp_cfg = { + .descs = (const struct msm_dp_desc[]) { + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort }, + }, + .num_descs = 1, +}; + static const struct of_device_id dp_dt_match[] = { { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg }, { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg }, + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg }, {} };
The Qualcomm SM8350 platform comes with a single DisplayPort controller, add support for this in the DisplayPort driver. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- .../devicetree/bindings/display/msm/dp-controller.yaml | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++ 2 files changed, 9 insertions(+)