| Message ID | 20220112194118.178026-12-luca@z3ntu.xyz |
|---|---|
| State | New |
| Headers | show |
| Series | Initial MSM8953 & Fairphone 3 support | expand |
On 2022-01-12 19:41, Luca Weiss wrote: > From: Vladimir Lypak <vladimir.lypak@gmail.com> > > Add a base DT for PM8953 PMIC, commonly used with MSM8953. > > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > arch/arm64/boot/dts/qcom/pm8953.dtsi | 90 ++++++++++++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pm8953.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi > b/arch/arm64/boot/dts/qcom/pm8953.dtsi > new file mode 100644 > index 000000000000..102555b3f313 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi > @@ -0,0 +1,90 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */ > + > +#include <dt-bindings/iio/qcom,spmi-vadc.h> > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/input/linux-event-codes.h> > +#include <dt-bindings/spmi/spmi.h> > + > +&spmi_bus { > + pmic@0 { > + compatible = "qcom,pm8953", "qcom,spmi-pmic"; > + reg = <0 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@6000 { > + compatible = "qcom,pm8941-rtc"; > + reg = <0x6000>, <0x6100>; > + reg-names = "rtc", "alarm"; > + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; > + }; > + > + pm8953_pon: pon@800 { > + compatible = "qcom,pm8916-pon"; > + reg = <0x800>; > + mode-bootloader = <0x2>; > + mode-recovery = <0x1>; > + > + pwrkey { > + compatible = "qcom,pm8941-pwrkey"; > + interrupts = <0x00 0x08 0 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = <KEY_POWER>; > + }; > + > + pm8953_resin: resin { > + compatible = "qcom,pm8941-resin"; > + interrupts = <0x00 0x08 1 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + status = "disabled"; > + }; > + }; > + > + temp-alarm@2400 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400>; > + interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>; > + io-channels = <&pm8953_vadc 0x08>; > + io-channel-names = "thermal"; > + #thermal-sensor-cells = <0x00>; > + }; > + > + pm8953_vadc: vadc@3100 { > + compatible = "qcom,spmi-vadc"; > + reg = <0x3100>; > + interrupts = <0x00 0x31 0x00 0x01>; > + #address-cells = <1>; > + #size-cells = <0>; > + #io-channel-cells = <1>; > + > + die_temp@8 { > + reg = <VADC_DIE_TEMP>; > + }; > + ref_625mv@9 { > + reg = <VADC_REF_625MV>; > + }; > + ref_1250v@a { > + reg = <VADC_REF_1250MV>; > + }; > + ref_buf_625mv@c { > + reg = <VADC_SPARE1>; > + }; > + ref_gnd@e { > + reg = <VADC_GND_REF>; > + }; > + ref_vdd@f { > + reg = <VADC_VDD_VADC>; > + }; Could you use the generic names for each VADC channel as recommended in qcom,spmi-vadc.yaml? > + }; > + }; > + > + pmic@1 { > + compatible = "qcom,pm8953", "qcom,spmi-pmic"; > + reg = <1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > +};
On 2022-01-12 19:41, Luca Weiss wrote: > From: Vladimir Lypak <vladimir.lypak@gmail.com> > > Add a base DT for PM8953 PMIC, commonly used with MSM8953. > > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > arch/arm64/boot/dts/qcom/pm8953.dtsi | 90 ++++++++++++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pm8953.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi > b/arch/arm64/boot/dts/qcom/pm8953.dtsi > new file mode 100644 > index 000000000000..102555b3f313 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi > @@ -0,0 +1,90 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */ > + > +#include <dt-bindings/iio/qcom,spmi-vadc.h> > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/input/linux-event-codes.h> > +#include <dt-bindings/spmi/spmi.h> > + > +&spmi_bus { > + pmic@0 { > + compatible = "qcom,pm8953", "qcom,spmi-pmic"; > + reg = <0 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@6000 { > + compatible = "qcom,pm8941-rtc"; > + reg = <0x6000>, <0x6100>; > + reg-names = "rtc", "alarm"; > + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; > + }; Could you sort the nodes by order? The rtc@6000 node should be after vadc@3100. > + > + pm8953_pon: pon@800 { > + compatible = "qcom,pm8916-pon"; > + reg = <0x800>; > + mode-bootloader = <0x2>; > + mode-recovery = <0x1>; > + > + pwrkey { > + compatible = "qcom,pm8941-pwrkey"; > + interrupts = <0x00 0x08 0 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = <KEY_POWER>; > + }; > + > + pm8953_resin: resin { > + compatible = "qcom,pm8941-resin"; > + interrupts = <0x00 0x08 1 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + status = "disabled"; > + }; > + }; > + > + temp-alarm@2400 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400>; > + interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>; > + io-channels = <&pm8953_vadc 0x08>; Could you use VADC_DIE_TEMP here instead of 0x08 like in qcom-spmi-temp-alarm.txt? > + io-channel-names = "thermal"; > + #thermal-sensor-cells = <0x00>; This should be "#thermal-sensor-cells = <0>;" as recommended by docs. > + }; > + > + pm8953_vadc: vadc@3100 { > + compatible = "qcom,spmi-vadc"; > + reg = <0x3100>; > + interrupts = <0x00 0x31 0x00 0x01>; > + #address-cells = <1>; > + #size-cells = <0>; > + #io-channel-cells = <1>; > + > + die_temp@8 { > + reg = <VADC_DIE_TEMP>; > + }; > + ref_625mv@9 { > + reg = <VADC_REF_625MV>; > + }; > + ref_1250v@a { > + reg = <VADC_REF_1250MV>; > + }; > + ref_buf_625mv@c { > + reg = <VADC_SPARE1>; > + }; > + ref_gnd@e { > + reg = <VADC_GND_REF>; > + }; > + ref_vdd@f { > + reg = <VADC_VDD_VADC>; > + }; Could you use the generic names for each VADC channel as recommended in qcom,spmi-vadc.yaml? > + }; > + }; > + > + pmic@1 { > + compatible = "qcom,pm8953", "qcom,spmi-pmic"; > + reg = <1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > +}; With this sorted, add my Reviewed-by. Reviewed-by: Rayyan Ansari <rayyan@ansari.sh>
diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi b/arch/arm64/boot/dts/qcom/pm8953.dtsi new file mode 100644 index 000000000000..102555b3f313 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */ + +#include <dt-bindings/iio/qcom,spmi-vadc.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/spmi/spmi.h> + +&spmi_bus { + pmic@0 { + compatible = "qcom,pm8953", "qcom,spmi-pmic"; + reg = <0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + rtc@6000 { + compatible = "qcom,pm8941-rtc"; + reg = <0x6000>, <0x6100>; + reg-names = "rtc", "alarm"; + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; + }; + + pm8953_pon: pon@800 { + compatible = "qcom,pm8916-pon"; + reg = <0x800>; + mode-bootloader = <0x2>; + mode-recovery = <0x1>; + + pwrkey { + compatible = "qcom,pm8941-pwrkey"; + interrupts = <0x00 0x08 0 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + linux,code = <KEY_POWER>; + }; + + pm8953_resin: resin { + compatible = "qcom,pm8941-resin"; + interrupts = <0x00 0x08 1 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + status = "disabled"; + }; + }; + + temp-alarm@2400 { + compatible = "qcom,spmi-temp-alarm"; + reg = <0x2400>; + interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>; + io-channels = <&pm8953_vadc 0x08>; + io-channel-names = "thermal"; + #thermal-sensor-cells = <0x00>; + }; + + pm8953_vadc: vadc@3100 { + compatible = "qcom,spmi-vadc"; + reg = <0x3100>; + interrupts = <0x00 0x31 0x00 0x01>; + #address-cells = <1>; + #size-cells = <0>; + #io-channel-cells = <1>; + + die_temp@8 { + reg = <VADC_DIE_TEMP>; + }; + ref_625mv@9 { + reg = <VADC_REF_625MV>; + }; + ref_1250v@a { + reg = <VADC_REF_1250MV>; + }; + ref_buf_625mv@c { + reg = <VADC_SPARE1>; + }; + ref_gnd@e { + reg = <VADC_GND_REF>; + }; + ref_vdd@f { + reg = <VADC_VDD_VADC>; + }; + }; + }; + + pmic@1 { + compatible = "qcom,pm8953", "qcom,spmi-pmic"; + reg = <1 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + }; +};