| Message ID | 20220111175430.224421-4-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | regulator/mfd: dt-bindings: maxim,max77802: convert to dtschema | expand |
On Tue, 11 Jan 2022 18:54:30 +0100, Krzysztof Kozlowski wrote: > The max77693 LED device node should not take an unit address, because it > is instantiated from a max77693 I2C parent device node. This also > splits all examples to separate DTS examples because they are actually > independent. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > Documentation/devicetree/bindings/leds/common.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 11/01/2022 18:54, Krzysztof Kozlowski wrote: > The max77693 LED device node should not take an unit address, because it > is instantiated from a max77693 I2C parent device node. This also > splits all examples to separate DTS examples because they are actually > independent. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > Documentation/devicetree/bindings/leds/common.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > This should be part of my max77693 patchset: https://lore.kernel.org/lkml/20220111175017.223966-1-krzysztof.kozlowski@canonical.com/ Nothing actually depends on this patch. It just fixes a warning which will be brought to eyes with mentioned max77693 patchset. Pavel, feel free to take it separately via leds tree. Other way is to take it with other max77693 patches (probably via MFD tree). Best regards, Krzysztof
Hi! > > The max77693 LED device node should not take an unit address, because it > > is instantiated from a max77693 I2C parent device node. This also > > splits all examples to separate DTS examples because they are actually > > independent. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > Documentation/devicetree/bindings/leds/common.yaml | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > This should be part of my max77693 patchset: > https://lore.kernel.org/lkml/20220111175017.223966-1-krzysztof.kozlowski@canonical.com/ > > Nothing actually depends on this patch. It just fixes a warning which > will be brought to eyes with mentioned max77693 patchset. > > Pavel, feel free to take it separately via leds tree. Other way is to > take it with other max77693 patches (probably via MFD tree). Ok, let me take it separately. Applied, thanks. Best regards, Pavel
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 697102707703..328952d7acbb 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -185,9 +185,11 @@ examples: }; }; - led-controller@0 { + - | + #include <dt-bindings/leds/common.h> + + led-controller { compatible = "maxim,max77693-led"; - reg = <0 0x100>; led { function = LED_FUNCTION_FLASH; @@ -199,6 +201,9 @@ examples: }; }; + - | + #include <dt-bindings/leds/common.h> + i2c { #address-cells = <1>; #size-cells = <0>;
The max77693 LED device node should not take an unit address, because it is instantiated from a max77693 I2C parent device node. This also splits all examples to separate DTS examples because they are actually independent. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Documentation/devicetree/bindings/leds/common.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)