| Message ID | 20220218104725.2718904-1-romain.naour@smile.fr |
|---|---|
| State | New |
| Headers | show |
| Series | drivers/thermal/ti-soc-thermal: Add hwmon support | expand |
Hi Romain, I'll apply the patch. In the future, use the scripts/get_maintainer.pl -f <file> to get the recipients of your patch if you have a doubt about who to send it to. Thanks -- Daniel On 18/02/2022 11:47, Romain Naour wrote: > Expose ti-soc-thermal thermal sensors as HWMON devices. > > # sensors > cpu_thermal-virtual-0 > Adapter: Virtual device > temp1: +54.2 C (crit = +105.0 C) > > dspeve_thermal-virtual-0 > Adapter: Virtual device > temp1: +51.4 C (crit = +105.0 C) > > gpu_thermal-virtual-0 > Adapter: Virtual device > temp1: +54.2 C (crit = +105.0 C) > > iva_thermal-virtual-0 > Adapter: Virtual device > temp1: +54.6 C (crit = +105.0 C) > > core_thermal-virtual-0 > Adapter: Virtual device > temp1: +52.6 C (crit = +105.0 C) > > Similar to imx_sc_thermal d2bc4dd91da6095a769fdc9bc519d3be7ad5f97a. > > No need to take care of thermal_remove_hwmon_sysfs() since > devm_thermal_add_hwmon_sysfs() (a wrapper around devres) is > used. See c7fc403e40b0ea18976a59e968c23439a80809e8. > > Signed-off-by: Romain Naour <romain.naour@smile.fr> > --- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > index f84375865c97..0959632b2170 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > @@ -21,6 +21,7 @@ > > #include "ti-thermal.h" > #include "ti-bandgap.h" > +#include "../thermal_hwmon.h" > > /* common data structures */ > struct ti_thermal_data { > @@ -189,6 +190,9 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id, > ti_bandgap_set_sensor_data(bgp, id, data); > ti_bandgap_write_update_interval(bgp, data->sensor_id, interval); > > + if (devm_thermal_add_hwmon_sysfs(data->ti_thermal)) > + dev_warn(bgp->dev, "failed to add hwmon sysfs attributes\n"); > + > return 0; > } >
Hi Daniel, Le 25/02/2022 à 12:46, Daniel Lezcano a écrit : > > Hi Romain, > > I'll apply the patch. You're welcome! > > In the future, use the scripts/get_maintainer.pl -f <file> to get the recipients > of your patch if you have a doubt about who to send it to. I wasn't sure if it was needed to send the patch to both mailing list. I was only subscribed to linux-omap until now. Best regards, Romain > > Thanks > > -- Daniel > > On 18/02/2022 11:47, Romain Naour wrote: >> Expose ti-soc-thermal thermal sensors as HWMON devices. >> >> # sensors >> cpu_thermal-virtual-0 >> Adapter: Virtual device >> temp1: +54.2 C (crit = +105.0 C) >> >> dspeve_thermal-virtual-0 >> Adapter: Virtual device >> temp1: +51.4 C (crit = +105.0 C) >> >> gpu_thermal-virtual-0 >> Adapter: Virtual device >> temp1: +54.2 C (crit = +105.0 C) >> >> iva_thermal-virtual-0 >> Adapter: Virtual device >> temp1: +54.6 C (crit = +105.0 C) >> >> core_thermal-virtual-0 >> Adapter: Virtual device >> temp1: +52.6 C (crit = +105.0 C) >> >> Similar to imx_sc_thermal d2bc4dd91da6095a769fdc9bc519d3be7ad5f97a. >> >> No need to take care of thermal_remove_hwmon_sysfs() since >> devm_thermal_add_hwmon_sysfs() (a wrapper around devres) is >> used. See c7fc403e40b0ea18976a59e968c23439a80809e8. >> >> Signed-off-by: Romain Naour <romain.naour@smile.fr> >> --- >> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c >> b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c >> index f84375865c97..0959632b2170 100644 >> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c >> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c >> @@ -21,6 +21,7 @@ >> #include "ti-thermal.h" >> #include "ti-bandgap.h" >> +#include "../thermal_hwmon.h" >> /* common data structures */ >> struct ti_thermal_data { >> @@ -189,6 +190,9 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id, >> ti_bandgap_set_sensor_data(bgp, id, data); >> ti_bandgap_write_update_interval(bgp, data->sensor_id, interval); >> + if (devm_thermal_add_hwmon_sysfs(data->ti_thermal)) >> + dev_warn(bgp->dev, "failed to add hwmon sysfs attributes\n"); >> + >> return 0; >> } >> > >
diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c index f84375865c97..0959632b2170 100644 --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c @@ -21,6 +21,7 @@ #include "ti-thermal.h" #include "ti-bandgap.h" +#include "../thermal_hwmon.h" /* common data structures */ struct ti_thermal_data { @@ -189,6 +190,9 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id, ti_bandgap_set_sensor_data(bgp, id, data); ti_bandgap_write_update_interval(bgp, data->sensor_id, interval); + if (devm_thermal_add_hwmon_sysfs(data->ti_thermal)) + dev_warn(bgp->dev, "failed to add hwmon sysfs attributes\n"); + return 0; }
Expose ti-soc-thermal thermal sensors as HWMON devices. # sensors cpu_thermal-virtual-0 Adapter: Virtual device temp1: +54.2 C (crit = +105.0 C) dspeve_thermal-virtual-0 Adapter: Virtual device temp1: +51.4 C (crit = +105.0 C) gpu_thermal-virtual-0 Adapter: Virtual device temp1: +54.2 C (crit = +105.0 C) iva_thermal-virtual-0 Adapter: Virtual device temp1: +54.6 C (crit = +105.0 C) core_thermal-virtual-0 Adapter: Virtual device temp1: +52.6 C (crit = +105.0 C) Similar to imx_sc_thermal d2bc4dd91da6095a769fdc9bc519d3be7ad5f97a. No need to take care of thermal_remove_hwmon_sysfs() since devm_thermal_add_hwmon_sysfs() (a wrapper around devres) is used. See c7fc403e40b0ea18976a59e968c23439a80809e8. Signed-off-by: Romain Naour <romain.naour@smile.fr> --- drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 4 ++++ 1 file changed, 4 insertions(+)