| Message ID | cover.1643360652.git.geert@linux-m68k.org |
|---|---|
| Headers | show |
| Series | dt-bindings: timer: sifive, clint: Miscellaneous improvements | expand |
> The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems", using the architectural > maximum of 4095 interrupts. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > v4: > - Use architectural maximum instead of practical maximum of 10, > > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index 8d5f4687add9e81e..fe4b73c3f269fc0f 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -44,6 +44,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 4095 > > additionalProperties: false > > -- > 2.25.1 Clears errors on the icicle dt, so fwiw: Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Fri, Jan 28, 2022 at 3:07 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi all, > > This patch series contains two improvements for the SiFive CLINT DT > bindings. > > Changes compared to v3[1]: > - Use architectural maximum instead of practical maximum of 10, > - Add Reviewed-by (this time for real ;-). > > Changes compared to v2[2]: > - Add Acked-by, Reviewed-by. > > Changes compared to v1[3]: > - Split in two patches, > - Improve patch description and document limit rationale. > > Thanks! > > [1] https://lore.kernel.org/r/cover.1639744468.git.geert@linux-m68k.org/ > [2] https://lore.kernel.org/r/cover.1639662093.git.geert@linux-m68k.org > [3] https://lore.kernel.org/r/20211125152317.162958-1-geert@linux-m68k.org > > Geert Uytterhoeven (2): > dt-bindings: timer: sifive,clint: Fix number of interrupts > dt-bindings: timer: sifive,clint: Group interrupt tuples > > .../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) As these have not been picked up yet, I've applied them. Rob