| Message ID | 20220225173734.GA7573@standask-GA-A55M-S2HP |
|---|---|
| State | Accepted |
| Commit | fa2024c315135d8319001363f1e456dcd0d9b51e |
| Headers | show |
| Series | dt-bindings: timer: Convert rda,8810pl-timer to YAML | expand |
On 25/02/2022 18:37, Stanislav Jakubek wrote: > Convert RDA Micro Timer bindings to DT schema format. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > --- > .../bindings/timer/rda,8810pl-timer.txt | 20 -------- > .../bindings/timer/rda,8810pl-timer.yaml | 47 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 48 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt > create mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On Fri, Feb 25, 2022 at 06:37:34PM +0100, Stanislav Jakubek wrote: > Convert RDA Micro Timer bindings to DT schema format. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > .../bindings/timer/rda,8810pl-timer.txt | 20 -------- > .../bindings/timer/rda,8810pl-timer.yaml | 47 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 48 insertions(+), 21 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt > create mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt > deleted file mode 100644 > index 4db542c9a0fd..000000000000 > --- a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt > +++ /dev/null > @@ -1,20 +0,0 @@ > -RDA Micro RDA8810PL Timer > - > -Required properties: > -- compatible : "rda,8810pl-timer" > -- reg : Offset and length of the register set for the device. > -- interrupts : Should contain two interrupts. > -- interrupt-names : Should be "hwtimer", "ostimer". > - > -Example: > - > - apb@20900000 { > - compatible = "simple-bus"; > - ... > - timer@10000 { > - compatible = "rda,8810pl-timer"; > - reg = <0x10000 0x1000>; > - interrupts = <16 IRQ_TYPE_LEVEL_HIGH>, > - <17 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "hwtimer", "ostimer"; > - }; > diff --git a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml > new file mode 100644 > index 000000000000..f9043a4488d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/rda,8810pl-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: RDA Micro RDA8810PL Timer > + > +maintainers: > + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > + > +properties: > + compatible: > + const: rda,8810pl-timer > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 2 > + maxItems: 2 > + > + interrupt-names: > + items: > + - const: hwtimer > + - const: ostimer > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + timer@20910000 { > + compatible = "rda,8810pl-timer"; > + reg = <0x20910000 0x1000>; > + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>, > + <17 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "hwtimer", "ostimer"; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 6d5c2c035f82..cbf91f0ecbfb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2563,7 +2563,7 @@ F: Documentation/devicetree/bindings/arm/rda.yaml > F: Documentation/devicetree/bindings/gpio/gpio-rda.yaml > F: Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt > F: Documentation/devicetree/bindings/serial/rda,8810pl-uart.yaml > -F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt > +F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml > F: arch/arm/boot/dts/rda8810pl-* > F: drivers/clocksource/timer-rda.c > F: drivers/gpio/gpio-rda.c > -- > 2.25.1 >
On 15/03/2022 15:01, Stanislav Jakubek wrote: > Hi all, > > anything holding this back? It's been sitting on the mailing lists > with 2 R-B's for ~2 weeks. Maybe it's too late in the cycle for Daniel to take this? Daniel, If you are waiting for Rob's ack, mine should be sufficient. Best regards, Krzysztof
On 15/03/2022 19:26, Krzysztof Kozlowski wrote: > On 15/03/2022 15:01, Stanislav Jakubek wrote: >> Hi all, >> >> anything holding this back? It's been sitting on the mailing lists >> with 2 R-B's for ~2 weeks. > > Maybe it's too late in the cycle for Daniel to take this? > > Daniel, > > If you are waiting for Rob's ack, mine should be sufficient. Right usually, I'm waiting for Rob's ack before picking these changes.
On 15/03/2022 20:02, Daniel Lezcano wrote: > On 15/03/2022 19:26, Krzysztof Kozlowski wrote: >> On 15/03/2022 15:01, Stanislav Jakubek wrote: >>> Hi all, >>> >>> anything holding this back? It's been sitting on the mailing lists >>> with 2 R-B's for ~2 weeks. >> >> Maybe it's too late in the cycle for Daniel to take this? >> >> Daniel, >> >> If you are waiting for Rob's ack, mine should be sufficient. > > Right usually, I'm waiting for Rob's ack before picking these changes. Which is fine :) but for the record (since information spreads slowly): https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=d029175f1420931e8d855868d264c4685687f3fd Best regards, Krzysztof
On 16/03/2022 09:25, Krzysztof Kozlowski wrote: > On 15/03/2022 20:02, Daniel Lezcano wrote: >> On 15/03/2022 19:26, Krzysztof Kozlowski wrote: >>> On 15/03/2022 15:01, Stanislav Jakubek wrote: >>>> Hi all, >>>> >>>> anything holding this back? It's been sitting on the mailing lists >>>> with 2 R-B's for ~2 weeks. >>> >>> Maybe it's too late in the cycle for Daniel to take this? >>> >>> Daniel, >>> >>> If you are waiting for Rob's ack, mine should be sufficient. >> >> Right usually, I'm waiting for Rob's ack before picking these changes. > > Which is fine :) but for the record (since information spreads slowly): > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=d029175f1420931e8d855868d264c4685687f3fd Ah, ok excellent Thanks for pointing this out, I'll pick the series
diff --git a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt deleted file mode 100644 index 4db542c9a0fd..000000000000 --- a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt +++ /dev/null @@ -1,20 +0,0 @@ -RDA Micro RDA8810PL Timer - -Required properties: -- compatible : "rda,8810pl-timer" -- reg : Offset and length of the register set for the device. -- interrupts : Should contain two interrupts. -- interrupt-names : Should be "hwtimer", "ostimer". - -Example: - - apb@20900000 { - compatible = "simple-bus"; - ... - timer@10000 { - compatible = "rda,8810pl-timer"; - reg = <0x10000 0x1000>; - interrupts = <16 IRQ_TYPE_LEVEL_HIGH>, - <17 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "hwtimer", "ostimer"; - }; diff --git a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml new file mode 100644 index 000000000000..f9043a4488d6 --- /dev/null +++ b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/rda,8810pl-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RDA Micro RDA8810PL Timer + +maintainers: + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> + +properties: + compatible: + const: rda,8810pl-timer + + reg: + maxItems: 1 + + interrupts: + minItems: 2 + maxItems: 2 + + interrupt-names: + items: + - const: hwtimer + - const: ostimer + +required: + - compatible + - reg + - interrupts + - interrupt-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + timer@20910000 { + compatible = "rda,8810pl-timer"; + reg = <0x20910000 0x1000>; + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>, + <17 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "hwtimer", "ostimer"; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 6d5c2c035f82..cbf91f0ecbfb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2563,7 +2563,7 @@ F: Documentation/devicetree/bindings/arm/rda.yaml F: Documentation/devicetree/bindings/gpio/gpio-rda.yaml F: Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt F: Documentation/devicetree/bindings/serial/rda,8810pl-uart.yaml -F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt +F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml F: arch/arm/boot/dts/rda8810pl-* F: drivers/clocksource/timer-rda.c F: drivers/gpio/gpio-rda.c
Convert RDA Micro Timer bindings to DT schema format. Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> --- .../bindings/timer/rda,8810pl-timer.txt | 20 -------- .../bindings/timer/rda,8810pl-timer.yaml | 47 +++++++++++++++++++ MAINTAINERS | 2 +- 3 files changed, 48 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml