| Message ID | 20220406233648.21644-2-brad@pensando.io |
|---|---|
| State | New |
| Headers | show |
| Series | Support Pensando Elba SoC | expand |
On 07/04/2022 01:36, Brad Larson wrote: > Document the compatible for Pensando Elba SoC boards. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Change from V3: > - Add description and board compatible That's a bit confusing... the subject is for v1. > > .../bindings/arm/pensando,elba.yaml | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/pensando,elba.yaml > > diff --git a/Documentation/devicetree/bindings/arm/pensando,elba.yaml b/Documentation/devicetree/bindings/arm/pensando,elba.yaml > new file mode 100644 > index 000000000000..61225f2d6ce5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/pensando,elba.yaml > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/pensando,elba.yaml# I propose just pensando.yaml, unless there is going to be hundreds of different families of SoC from Pensando? This patch should be after adding the vendor prefix. Best regards, Krzysztof
On 07/04/2022 01:36, Brad Larson wrote: > Document the compatible for Pensando Elba SoC boards. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Change from V3: > - Add description and board compatible > > .../bindings/arm/pensando,elba.yaml | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/pensando,elba.yaml > > diff --git a/Documentation/devicetree/bindings/arm/pensando,elba.yaml b/Documentation/devicetree/bindings/arm/pensando,elba.yaml It seems you ignored to Cc devicetree binding maintainers for all your devicetree bindings patches. Please rebase on a recent kernel tree and use scripts/get_maintainers.pl to get list of people to Cc. Your tree could not have my address, but why Rob is missing is a surprise... Best regards, Krzysztof
On Thu, Apr 7, 2022 at 11:54 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > diff --git a/Documentation/devicetree/bindings/arm/pensando,elba.yaml b/Documentation/devicetree/bindings/arm/pensando,elba.yaml > > It seems you ignored to Cc devicetree binding maintainers for all your > devicetree bindings patches. > > Please rebase on a recent kernel tree and use scripts/get_maintainers.pl > to get list of people to Cc. Your tree could not have my address, but > why Rob is missing is a surprise... Hi Krzysztof, Thanks for pointing this out. I used get_maintainers.pl on the original patchset that has evolved. I will redo the list for the next submission. Best, Brad
On Thu, Apr 7, 2022 at 11:45 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Change from V3: > > - Add description and board compatible > > That's a bit confusing... the subject is for v1. Goal was to identify in the cover letter patch the key changes from the V3 patchset to this V4 patchset. Then in each patch that had a material change highlight that in the patch itself. Will try and make it more clear. > > +$id: http://devicetree.org/schemas/arm/pensando,elba.yaml# > > I propose just pensando.yaml, unless there is going to be hundreds of > different families of SoC from Pensando? > > This patch should be after adding the vendor prefix. pensando.yaml is good, I'll change it to that. I'll order this patch to be after the vendor prefix addition in the next submission. Best, Brad
On 09/04/2022 04:19, Brad Larson wrote: > On Thu, Apr 7, 2022 at 11:45 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >>> Change from V3: >>> - Add description and board compatible >> >> That's a bit confusing... the subject is for v1. > > Goal was to identify in the cover letter patch the key changes from > the V3 patchset to this V4 patchset. Then in each patch that had a > material change highlight that in the patch itself. Will try and make > it more clear. This is fine, I am talking about the subject - it is marked as a v1, so it's confusing to see a changelog. One way to achieve this is: "git format-patch -v4 -11 ..." Best regards, Krzysztof
On Sat, Apr 09, 2022 at 12:39:59PM +0200, Krzysztof Kozlowski wrote: > On 09/04/2022 04:19, Brad Larson wrote: > > On Thu, Apr 7, 2022 at 11:45 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >>> Change from V3: > >>> - Add description and board compatible > >> > >> That's a bit confusing... the subject is for v1. > > > > Goal was to identify in the cover letter patch the key changes from > > the V3 patchset to this V4 patchset. Then in each patch that had a > > material change highlight that in the patch itself. Will try and make > > it more clear. > > This is fine, I am talking about the subject - it is marked as a v1, so > it's confusing to see a changelog. > > One way to achieve this is: "git format-patch -v4 -11 ..." v2 was submitted by Brad one year ago: https://patches.linaro.org/project/linux-spi/cover/20210329015938.20316-1-brad@pensando.io/ most likely he has just forgotten to add the proper suffix. -Sergey > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/pensando,elba.yaml b/Documentation/devicetree/bindings/arm/pensando,elba.yaml new file mode 100644 index 000000000000..61225f2d6ce5 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/pensando,elba.yaml @@ -0,0 +1,26 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/pensando,elba.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Pensando Elba SoC Platforms Device Tree Bindings + +maintainers: + - Brad Larson <brad@pensando.io> + +properties: + $nodename: + const: "/" + compatible: + oneOf: + + - description: Boards with Elba SoC + items: + - enum: + - pensando,elba-ortano + - const: pensando,elba + +additionalProperties: true + +...
Document the compatible for Pensando Elba SoC boards. Signed-off-by: Brad Larson <brad@pensando.io> --- Change from V3: - Add description and board compatible .../bindings/arm/pensando,elba.yaml | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/pensando,elba.yaml