mbox series

[00/15] am335x, guardian: update board specific dts changes

Message ID 20220325100613.1494-1-Gireesh.Hiremath@in.bosch.com
Headers show
Series am335x, guardian: update board specific dts changes | expand

Message

Gireesh.Hiremath@in.bosch.com March 25, 2022, 10:05 a.m. UTC 
From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

update guardian device tree

Gireesh Hiremath (15):
  ARM: dts: am335x: Guardian: Update NAND partition table
  ARM: dts: am335x: Guardian: Rename power button label
  ARM: dts: am335x: Guardian: Add keypad
  ARM: dts: am335x: Guardian: Disable poweroff support from RTC
  ARM: dts: am335x: Guardian: Remove mmc status led
  ARM: dts: am335x: Guardian: Update life led
  ARM: dts: am335x: Guardian: Update beeper label
  ARM: dts: am335x: Guardian: Update regulator node name
  ARM: dts: am335x: Guardian: Add lcd port
  ARM: dts: am335x: Guardian: Update backlight parameter
  ARM: dts: am335x: Guardian: Enable UART port two
  ARM: dts: am335x: Guardian: Disable DMA property of USB1
  ARM: dts: am335x: Guardian: Update interface pinmux
  ARM: dts: am335x: Guardian: Add gpio line manes
  ARM: dts: am335x: Guardian: Update comments

 arch/arm/boot/dts/am335x-guardian.dts | 376 ++++++++++++++++++++++----
 1 file changed, 316 insertions(+), 60 deletions(-)

Comments

Tony Lindgren April 21, 2022, 11:08 a.m. UTC | #1 
* Gireesh.Hiremath@in.bosch.com <Gireesh.Hiremath@in.bosch.com> [220325 12:04]:
> From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>
> 
> update guardian device tree

Thanks applying into omap-for-v5.19/dt.

Few ideas for future though.

Not sure how you handle the nand partition table changes.. Seems the partition
values in the devicetree should not change in general.

The node names in devicetree should not use "_" but "-" instead. And the node
names should be general like you mostly already have. Anyways, we have a lot
of these especially for pinctrl, but we may want to clean them up eventually.
Just FYI.

Regards,

Tony