| Message ID | 20220513010359.1061926-1-luiz.dentz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ] hog-lib: Fix not able to read report_map of instances | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=641200 ---Test result--- Test Summary: CheckPatch PASS 1.38 seconds GitLint PASS 0.97 seconds Prep - Setup ELL PASS 42.17 seconds Build - Prep PASS 0.68 seconds Build - Configure PASS 8.37 seconds Build - Make PASS 1236.36 seconds Make Check PASS 11.29 seconds Make Check w/Valgrind PASS 438.89 seconds Make Distcheck PASS 227.75 seconds Build w/ext ELL - Configure PASS 8.65 seconds Build w/ext ELL - Make PASS 1238.95 seconds Incremental Build with patchesPASS 1263.53 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 12 May 2022 18:03:59 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > If there is multiple instances the gatt_db of the instances was not > initialized causing the report_map_attr to be NULL. > > Fixes: https://github.com/bluez/bluez/issues/298 > > [...] Here is the summary with links: - [BlueZ] hog-lib: Fix not able to read report_map of instances https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c7955b2099dc You are awesome, thank you!
diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c index e69ea1ba4..4a9c60185 100644 --- a/profiles/input/hog-lib.c +++ b/profiles/input/hog-lib.c @@ -1518,6 +1518,7 @@ static void hog_attach_instance(struct bt_hog *hog, if (!instance) return; + instance->gatt_db = gatt_db_ref(hog->gatt_db); hog->instances = g_slist_append(hog->instances, bt_hog_ref(instance)); } @@ -1557,6 +1558,8 @@ struct bt_hog *bt_hog_new(int fd, const char *name, uint16_t vendor, if (!hog) return NULL; + hog->gatt_db = gatt_db_ref(db); + if (db) { bt_uuid_t uuid; @@ -1573,8 +1576,6 @@ struct bt_hog *bt_hog_new(int fd, const char *name, uint16_t vendor, hog->dis = bt_dis_new(db); bt_dis_set_notification(hog->dis, dis_notify, hog); } - - hog->gatt_db = gatt_db_ref(db); } return bt_hog_ref(hog); @@ -1675,7 +1676,8 @@ static void hog_attach_hog(struct bt_hog *hog, struct gatt_primary *primary) } instance = bt_hog_new(hog->uhid_fd, hog->name, hog->vendor, - hog->product, hog->version, NULL); + hog->product, hog->version, + hog->gatt_db); if (!instance) return;
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> If there is multiple instances the gatt_db of the instances was not initialized causing the report_map_attr to be NULL. Fixes: https://github.com/bluez/bluez/issues/298 --- profiles/input/hog-lib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)