diff mbox series

[1/1] dt-bindings: i2c: i2c-rk3x: add rk3588 compatible

Message ID 20220623163136.246404-1-sebastian.reichel@collabora.com
State Accepted
Commit 066ab294504fe868eb90d8d34b3eeab9785d33f0
Headers show
Series [1/1] dt-bindings: i2c: i2c-rk3x: add rk3588 compatible | expand

Commit Message

Sebastian Reichel June 23, 2022, 4:31 p.m. UTC
Just like RK356x, RK3588 is compatible to the existing rk3399 binding.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski June 26, 2022, 8:22 p.m. UTC | #1
On 23/06/2022 18:31, Sebastian Reichel wrote:
> Just like RK356x, RK3588 is compatible to the existing rk3399 binding.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
>  1 file changed, 1 insertion(+)

That's still some old tree you are based on...

Best regards,
Krzysztof
Wolfram Sang July 6, 2022, 7:34 p.m. UTC | #2
On Sun, Jun 26, 2022 at 10:22:09PM +0200, Krzysztof Kozlowski wrote:
> On 23/06/2022 18:31, Sebastian Reichel wrote:
> > Just like RK356x, RK3588 is compatible to the existing rk3399 binding.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> 
> That's still some old tree you are based on...

What do you mean by that?
Krzysztof Kozlowski July 6, 2022, 7:55 p.m. UTC | #3
On 06/07/2022 21:34, Wolfram Sang wrote:
> On Sun, Jun 26, 2022 at 10:22:09PM +0200, Krzysztof Kozlowski wrote:
>> On 23/06/2022 18:31, Sebastian Reichel wrote:
>>> Just like RK356x, RK3588 is compatible to the existing rk3399 binding.
>>>
>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>>> ---
>>>  Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> That's still some old tree you are based on...
> 
> What do you mean by that?

The patch was sent to not updated email, so I assume it was based on
something before v5.18. Could be relevant, could be not, but it raises a
question what was a base this (and other Rockchip) series. :)

Best regards,
Krzysztof
Sebastian Reichel July 7, 2022, 12:11 a.m. UTC | #4
Hi,

On Wed, Jul 06, 2022 at 09:55:27PM +0200, Krzysztof Kozlowski wrote:
> On 06/07/2022 21:34, Wolfram Sang wrote:
> > On Sun, Jun 26, 2022 at 10:22:09PM +0200, Krzysztof Kozlowski wrote:
> >> On 23/06/2022 18:31, Sebastian Reichel wrote:
> >>> Just like RK356x, RK3588 is compatible to the existing rk3399 binding.
> >>>
> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>
> >> That's still some old tree you are based on...
> > 
> > What do you mean by that?
> 
> The patch was sent to not updated email, so I assume it was based on
> something before v5.18. Could be relevant, could be not, but it raises a
> question what was a base this (and other Rockchip) series. :)

The last round of rk3588 patches (incl. this one) are based on
v5.19-rc1, but mail destinations are not (I do not generate the
mail destinations fully automatic).

-- Sebastian
Wolfram Sang July 7, 2022, 9:09 p.m. UTC | #5
On Thu, Jun 23, 2022 at 06:31:36PM +0200, Sebastian Reichel wrote:
> Just like RK356x, RK3588 is compatible to the existing rk3399 binding.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
index 5339dd4fc370..2f79f6d57e2d 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
@@ -37,6 +37,7 @@  properties:
               - rockchip,rk3308-i2c
               - rockchip,rk3328-i2c
               - rockchip,rk3568-i2c
+              - rockchip,rk3588-i2c
           - const: rockchip,rk3399-i2c
 
   reg: