| Message ID | 20220703183449.12917-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | dt-bindings: hwinfo: group devices and add s5pv210-chipid | expand |
On 03/07/2022 20:34, Krzysztof Kozlowski wrote: > Hi, > > As suggested by Rob [1], I organized a bit bindings for SoC devices having > similar purpose - chip identification. > > These sometimes are put under nvmem directory, although in that case the > purpose is usually broader than just chipid. And the missing [1] link is: https://lore.kernel.org/all/20220701173524.GA1185040-robh@kernel.org/ Best regards, Krzysztof
Hi Krzysztof, On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > As suggested by Rob [1], I organized a bit bindings for SoC devices having > similar purpose - chip identification. > > These sometimes are put under nvmem directory, although in that case the > purpose is usually broader than just chipid. Thanks for your series! > dt-bindings: hwinfo: group Chip ID-like devices > dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID So why not call it "chipid"? "hwinfo" sounds too generic to me; aren't all DT bindings hardware information? > > .../{soc/renesas => hwinfo}/renesas,prr.yaml | 2 +- > .../samsung,exynos-chipid.yaml} | 2 +- > .../hwinfo/samsung,s5pv210-chipid.yaml | 30 +++++++++++++++++++ > .../ti,k3-socinfo.yaml} | 2 +- > MAINTAINERS | 3 ++ > 5 files changed, 36 insertions(+), 3 deletions(-) > rename Documentation/devicetree/bindings/{soc/renesas => hwinfo}/renesas,prr.yaml (92%) > rename Documentation/devicetree/bindings/{soc/samsung/exynos-chipid.yaml => hwinfo/samsung,exynos-chipid.yaml} (92%) > create mode 100644 Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml > rename Documentation/devicetree/bindings/{soc/ti/k3-socinfo.yaml => hwinfo/ti,k3-socinfo.yaml} (92%) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 04/07/2022 09:18, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> As suggested by Rob [1], I organized a bit bindings for SoC devices having >> similar purpose - chip identification. >> >> These sometimes are put under nvmem directory, although in that case the >> purpose is usually broader than just chipid. > > Thanks for your series! > >> dt-bindings: hwinfo: group Chip ID-like devices >> dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID > > So why not call it "chipid"? > "hwinfo" sounds too generic to me; aren't all DT bindings hardware > information? If it is too specific, some other similar drivers won't perfectly match thus they will be placed again under dt-bindings/soc. I was thinking about name "socinfo", but on the other hand why limiting to SoC? I think there are many more devices which provide some kind of read-only hardware information (type, revision, product ID, model etc), therefore - hwinfo. Thanks for the feedback. Best regards, Krzysztof
On Mon, Jul 04, 2022 at 09:18:31AM +0200, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > As suggested by Rob [1], I organized a bit bindings for SoC devices having > > similar purpose - chip identification. What's the base? It didn't apply for me. > > > > These sometimes are put under nvmem directory, although in that case the > > purpose is usually broader than just chipid. > > Thanks for your series! > > > dt-bindings: hwinfo: group Chip ID-like devices > > dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID > > So why not call it "chipid"? > "hwinfo" sounds too generic to me; aren't all DT bindings hardware > information? I'm fine with hwinfo as the color of the shed. I don't think we should encode where the information comes from. Rob
On 05/07/2022 16:51, Rob Herring wrote: > On Mon, Jul 04, 2022 at 09:18:31AM +0200, Geert Uytterhoeven wrote: >> Hi Krzysztof, >> >> On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski >> <krzysztof.kozlowski@linaro.org> wrote: >>> As suggested by Rob [1], I organized a bit bindings for SoC devices having >>> similar purpose - chip identification. > > What's the base? It didn't apply for me. The Renesas bits should go via Renesas tree. I'll split the series. Best regards, Krzysztof
Hi, As suggested by Rob [1], I organized a bit bindings for SoC devices having similar purpose - chip identification. These sometimes are put under nvmem directory, although in that case the purpose is usually broader than just chipid. Best regards, Krzysztof Krzysztof Kozlowski (2): dt-bindings: hwinfo: group Chip ID-like devices dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID .../{soc/renesas => hwinfo}/renesas,prr.yaml | 2 +- .../samsung,exynos-chipid.yaml} | 2 +- .../hwinfo/samsung,s5pv210-chipid.yaml | 30 +++++++++++++++++++ .../ti,k3-socinfo.yaml} | 2 +- MAINTAINERS | 3 ++ 5 files changed, 36 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/{soc/renesas => hwinfo}/renesas,prr.yaml (92%) rename Documentation/devicetree/bindings/{soc/samsung/exynos-chipid.yaml => hwinfo/samsung,exynos-chipid.yaml} (92%) create mode 100644 Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml rename Documentation/devicetree/bindings/{soc/ti/k3-socinfo.yaml => hwinfo/ti,k3-socinfo.yaml} (92%)