diff mbox series

scsi: ufs-qcom: Remove unneeded code

Message ID 20220627235545.16943-1-cw9316.lee@samsung.com
State New
Headers show
Series scsi: ufs-qcom: Remove unneeded code | expand

Commit Message

Chanwoo Lee June 27, 2022, 11:55 p.m. UTC 
From: ChanWoo Lee <cw9316.lee@samsung.com>

Checks information about tx_lanes, but is not used.

Since the commit below is applied, tx_lanes is deprecated.
 'commit 1e1e465c6d23
  ("scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host")'

As a result,
ufs_qcom_link_startup_notify -> POST_CHANGE action does nothing.
If it is not going to be updated, it looks like it can be removed.

Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
---
 drivers/ufs/host/ufs-qcom.c | 23 -----------------------
 1 file changed, 23 deletions(-)

Comments

Martin K. Petersen July 7, 2022, 9:47 p.m. UTC | #1 
On Tue, 28 Jun 2022 08:55:45 +0900, Chanwoo Lee wrote:

> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> Checks information about tx_lanes, but is not used.
> 
> Since the commit below is applied, tx_lanes is deprecated.
>  'commit 1e1e465c6d23
>   ("scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host")'
> 
> [...]

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: ufs-qcom: Remove unneeded code
      https://git.kernel.org/mkp/scsi/c/bcec04b3cce4
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index f10d4668814c..473fad83701e 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -58,19 +58,6 @@  static void ufs_qcom_dump_regs_wrapper(struct ufs_hba *hba, int offset, int len,
 	ufshcd_dump_regs(hba, offset, len * 4, prefix);
 }
 
-static int ufs_qcom_get_connected_tx_lanes(struct ufs_hba *hba, u32 *tx_lanes)
-{
-	int err = 0;
-
-	err = ufshcd_dme_get(hba,
-			UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), tx_lanes);
-	if (err)
-		dev_err(hba->dev, "%s: couldn't read PA_CONNECTEDTXDATALANES %d\n",
-				__func__, err);
-
-	return err;
-}
-
 static int ufs_qcom_host_clk_get(struct device *dev,
 		const char *name, struct clk **clk_out, bool optional)
 {
@@ -194,13 +181,6 @@  static int ufs_qcom_init_lane_clks(struct ufs_qcom_host *host)
 	return err;
 }
 
-static int ufs_qcom_link_startup_post_change(struct ufs_hba *hba)
-{
-	u32 tx_lanes;
-
-	return ufs_qcom_get_connected_tx_lanes(hba, &tx_lanes);
-}
-
 static int ufs_qcom_check_hibern8(struct ufs_hba *hba)
 {
 	int err;
@@ -569,9 +549,6 @@  static int ufs_qcom_link_startup_notify(struct ufs_hba *hba,
 		if (ufshcd_get_local_unipro_ver(hba) != UFS_UNIPRO_VER_1_41)
 			err = ufshcd_disable_host_tx_lcc(hba);
 
-		break;
-	case POST_CHANGE:
-		ufs_qcom_link_startup_post_change(hba);
 		break;
 	default:
 		break;