| Message ID | 20220712050857.267-1-13691752556@139.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5] update tas2780.yaml | expand |
On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote: > 1.remove unused item in DT 2.revise the format Again, fix your subject. Run 'git log --oneline Documentation/devicetree/bindings/sound/' for inspiration of the format of the subject. However, there's a bigger issue here. We already have a binding for this device. It's in tas27xx.yaml. And you added 2780 to it, so why did you add another schema? (All the same issues in that patch too. wrong subject, broken schema. So you haven't learned.) And then there is also tas2770.yaml which appears to be about the same as well. > > Signed-off-by: Raphael-Xu <13691752556@139.com> > --- > .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-)
Hi Rob, Please see my reply. -----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Wednesday, July 13, 2022 10:52 PM To: Raphael-Xu <13691752556@139.com> Cc: alsa-devel@alsa-project.org; Xu, Yang <raphael-xu@ti.com>; Ding, Shenghao <shenghao-ding@ti.com>; Navada Kanyana, Mukund <navada@ti.com>; Syrus, Andy <asyrus@ti.com>; broonie@kernel.org; devicetree@vger.kernel.org Subject: [EXTERNAL] Re: [PATCH v5] update tas2780.yaml On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote: > 1.remove unused item in DT 2.revise the format Again, fix your subject. Run 'git log --oneline Documentation/devicetree/bindings/sound/' for inspiration of the format of the subject. [RX]:just submit new patch However, there's a bigger issue here. We already have a binding for this device. It's in tas27xx.yaml. And you added 2780 to it, so why did you add another schema? (All the same issues in that patch too. wrong subject, broken schema. So you haven't learned.) [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. And then there is also tas2770.yaml which appears to be about the same as well. [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. > > Signed-off-by: Raphael-Xu <13691752556@139.com> > --- > .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-)
Hi Rob, One more question of tas27xx.yaml.Would you like us to delete tas27xx.yaml and submit new tas2764.yaml in updated format,or we just revert to old version tas2764.yaml commit? Thanks. Regards Raphael -----Original Message----- From: Xu, Yang <> Sent: Wednesday, July 20, 2022 11:48 AM To: 'Rob Herring' <robh@kernel.org>; Raphael-Xu <13691752556@139.com> Cc: alsa-devel@alsa-project.org; Ding, Shenghao <shenghao-ding@ti.com>; Navada Kanyana, Mukund <navada@ti.com>; Syrus, Andy <asyrus@ti.com>; broonie@kernel.org; devicetree@vger.kernel.org Subject: RE: [EXTERNAL] Re: [PATCH v5] update tas2780.yaml Hi Rob, Please see my reply. -----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Wednesday, July 13, 2022 10:52 PM To: Raphael-Xu <13691752556@139.com> Cc: alsa-devel@alsa-project.org; Xu, Yang <raphael-xu@ti.com>; Ding, Shenghao <shenghao-ding@ti.com>; Navada Kanyana, Mukund <navada@ti.com>; Syrus, Andy <asyrus@ti.com>; broonie@kernel.org; devicetree@vger.kernel.org Subject: [EXTERNAL] Re: [PATCH v5] update tas2780.yaml On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote: > 1.remove unused item in DT 2.revise the format Again, fix your subject. Run 'git log --oneline Documentation/devicetree/bindings/sound/' for inspiration of the format of the subject. [RX]:just submit new patch However, there's a bigger issue here. We already have a binding for this device. It's in tas27xx.yaml. And you added 2780 to it, so why did you add another schema? (All the same issues in that patch too. wrong subject, broken schema. So you haven't learned.) [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. And then there is also tas2770.yaml which appears to be about the same as well. [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. > > Signed-off-by: Raphael-Xu <13691752556@139.com> > --- > .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-)
On Tue, Jul 19, 2022 at 11:44 PM Xu, Yang <raphael-xu@ti.com> wrote: > > Hi Rob, > > One more question of tas27xx.yaml.Would you like us to delete tas27xx.yaml and submit new tas2764.yaml in updated format,or we just revert to old version tas2764.yaml commit? > Thanks. I think tas2770.yaml and tas2780.yaml should both be removed with ti,tas2770 compatible added to tas27xx.yaml. > > Regards > Raphael > > -----Original Message----- > From: Xu, Yang <> > Sent: Wednesday, July 20, 2022 11:48 AM > To: 'Rob Herring' <robh@kernel.org>; Raphael-Xu <13691752556@139.com> > Cc: alsa-devel@alsa-project.org; Ding, Shenghao <shenghao-ding@ti.com>; Navada Kanyana, Mukund <navada@ti.com>; Syrus, Andy <asyrus@ti.com>; broonie@kernel.org; devicetree@vger.kernel.org > Subject: RE: [EXTERNAL] Re: [PATCH v5] update tas2780.yaml > > Hi Rob, > > Please see my reply. > > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Wednesday, July 13, 2022 10:52 PM > To: Raphael-Xu <13691752556@139.com> > Cc: alsa-devel@alsa-project.org; Xu, Yang <raphael-xu@ti.com>; Ding, Shenghao <shenghao-ding@ti.com>; Navada Kanyana, Mukund <navada@ti.com>; Syrus, Andy <asyrus@ti.com>; broonie@kernel.org; devicetree@vger.kernel.org > Subject: [EXTERNAL] Re: [PATCH v5] update tas2780.yaml > > On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote: > > 1.remove unused item in DT 2.revise the format > > Again, fix your subject. Run 'git log --oneline Documentation/devicetree/bindings/sound/' for inspiration of the format of the subject. > [RX]:just submit new patch Closer, but still the wrong subject. You are missing spaces. > However, there's a bigger issue here. We already have a binding for this device. It's in tas27xx.yaml. And you added 2780 to it, so why did you add another schema? (All the same issues in that patch too. wrong subject, broken schema. So you haven't learned.) [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. > And then there is also tas2770.yaml which appears to be about the same as well. > [RX]:We will follow tas2780 patch format and submit separate patch if you think tas2780 patch is acceptable. Is deleting tas2780.yaml and just adding ti,tas2780 compatible not sufficient? Why fix tas2780.yaml and then delete it? Doing the same for tas2770 can be separate. Rob > > > > Signed-off-by: Raphael-Xu <13691752556@139.com> > > --- > > .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++-------- > > 1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/tas2780.yaml b/Documentation/devicetree/bindings/sound/tas2780.yaml index 5a0de0995066..21389a16fdb9 100644 --- a/Documentation/devicetree/bindings/sound/tas2780.yaml +++ b/Documentation/devicetree/bindings/sound/tas2780.yaml @@ -22,24 +22,29 @@ properties: - ti,tas2780 reg: - maxItems: 1 - description: | - I2C address of the device can be between 0x38 to 0x45. + description: + I2C address of the device can be between 0x38 to 0x3f. + minimum: 0x38 + maximum: 0x3f reset-gpios: - maxItems: 1 description: GPIO used to reset the device. + maxItems: 1 interrupts: maxItems: 1 ti,imon-slot-no: - $ref: /schemas/types.yaml#/definitions/uint32 description: TDM TX current sense time slot. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3 ti,vmon-slot-no: - $ref: /schemas/types.yaml#/definitions/uint32 description: TDM TX voltage sense time slot. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 3 '#sound-dai-cells': const: 1 @@ -60,10 +65,8 @@ examples: compatible = "ti,tas2780"; reg = <0x38>; #sound-dai-cells = <1>; - interrupt-parent = <&gpio1>; interrupts = <14>; reset-gpios = <&gpio1 15 0>; - shutdown-gpios = <&gpio1 15 0>; ti,imon-slot-no = <0>; ti,vmon-slot-no = <2>; };
1.remove unused item in DT 2.revise the format Signed-off-by: Raphael-Xu <13691752556@139.com> --- .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)