mbox series

[0/5] configure: fix some non-portabilities

Message ID 20220720152631.450903-1-peter.maydell@linaro.org
Headers show
Series configure: fix some non-portabilities | expand

Message

Peter Maydell July 20, 2022, 3:26 p.m. UTC 
This patchset fixes some non-portable code that has crept in recently:
notably, it fixes problems that are reported to cause configure
not to work correctly on OpenBSD and NetBSD, and a warning message
when using dash as /bin/sh on Linux. I threw in a less important
"drop some dead code" fix too, and a fix for the only other 'error'
category problem reported by shellcheck. (There are way too many
'warning' category reports to deal with all at once.)

If people who reported problems on NetBSD/OpenBSD could check that
this fixes them, that would be great.

thanks
-- PMM


Peter Maydell (5):
  configure: Add missing POSIX-required space
  configure: Add braces to clarify intent of $emu[[:space:]]
  configure: Don't use bash-specific string-replacement syntax
  configure: Drop dead code attempting to use -msmall-data on alpha
    hosts
  configure: Avoid '==' bashism

 configure | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

Comments

Peter Maydell July 26, 2022, 12:41 p.m. UTC | #1 
On Wed, 20 Jul 2022 at 16:26, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> This patchset fixes some non-portable code that has crept in recently:
> notably, it fixes problems that are reported to cause configure
> not to work correctly on OpenBSD and NetBSD, and a warning message
> when using dash as /bin/sh on Linux. I threw in a less important
> "drop some dead code" fix too, and a fix for the only other 'error'
> category problem reported by shellcheck. (There are way too many
> 'warning' category reports to deal with all at once.)
>
> If people who reported problems on NetBSD/OpenBSD could check that
> this fixes them, that would be great.

I'll take these via target-arm.next since I'm doing a pullreq anyway.

thanks
-- PMM