| Message ID | 20220815043436.20170-4-samuel@sholland.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/4] regulator: dt-bindings: Add Allwinner D1 LDOs | expand |
On 15/08/2022 07:34, Samuel Holland wrote: > Some sunxi SoCs have in-package regulators controlled by a register in > the system control MMIO block. Allow a child node for these regulators > in addition to SRAM child nodes. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > Changes in v3: > - Require the regulators node to have a unit address > - Reference the regulator schema from the SRAM controller schema > - Move the system LDOs example to the SRAM controller schema > - Reorder the patches so the example passes validation > > Changes in v2: > - New patch for v2 > > .../allwinner,sun4i-a10-system-control.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > index d64c1b28fb61..915ca85c3f10 100644 > --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > @@ -56,6 +56,10 @@ properties: > ranges: true > > patternProperties: > + "^regulators@[0-9a-f]+$": > + $ref: /schemas/regulator/allwinner,sun20i-d1-system-ldos.yaml# > + unevaluatedProperties: false unevaluatedProperties is not needed. Your other schema does not allow anything else here. > + > "^sram@[a-z0-9]+": > type: object > > @@ -130,3 +134,28 @@ examples: > }; > }; > }; > + > + - | > + syscon@3000000 { > + compatible = "allwinner,sun20i-d1-system-control"; Your other example uses simple-mfd, syscon... A bit confusing. > + reg = <0x3000000 0x1000>; > + ranges; > + #address-cells = <1>; > + #size-cells = <1>; > + > + regulators@3000150 { > + compatible = "allwinner,sun20i-d1-system-ldos"; > + reg = <0x3000150 0x4>; > + > + reg_ldoa: ldoa { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + reg_ldob: ldob { > + regulator-name = "vcc-dram"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + }; > + }; > + }; Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml index d64c1b28fb61..915ca85c3f10 100644 --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml @@ -56,6 +56,10 @@ properties: ranges: true patternProperties: + "^regulators@[0-9a-f]+$": + $ref: /schemas/regulator/allwinner,sun20i-d1-system-ldos.yaml# + unevaluatedProperties: false + "^sram@[a-z0-9]+": type: object @@ -130,3 +134,28 @@ examples: }; }; }; + + - | + syscon@3000000 { + compatible = "allwinner,sun20i-d1-system-control"; + reg = <0x3000000 0x1000>; + ranges; + #address-cells = <1>; + #size-cells = <1>; + + regulators@3000150 { + compatible = "allwinner,sun20i-d1-system-ldos"; + reg = <0x3000150 0x4>; + + reg_ldoa: ldoa { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + reg_ldob: ldob { + regulator-name = "vcc-dram"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + }; + }; + };
Some sunxi SoCs have in-package regulators controlled by a register in the system control MMIO block. Allow a child node for these regulators in addition to SRAM child nodes. Signed-off-by: Samuel Holland <samuel@sholland.org> --- Changes in v3: - Require the regulators node to have a unit address - Reference the regulator schema from the SRAM controller schema - Move the system LDOs example to the SRAM controller schema - Reorder the patches so the example passes validation Changes in v2: - New patch for v2 .../allwinner,sun4i-a10-system-control.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+)