| Message ID | 629afd26008c2b1ba5822799ea7ea5b5271895e8.1660903997.git.geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Commit | 5a0504945878b4af7534c1ce668a5678dc0201cf |
| Headers | show |
| Series | [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl | expand |
On 19/08/2022 11:14, Geert Uytterhoeven wrote: > "make dtbs_check" says: > > bias-disable: boolean property with value b'\x00\x00\x00\x00' > > Fix this by dropping the offending value. > > Fixes: be497abe19bf08fb ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Caleb Connolly <caleb@connolly.tech> > --- > Marked RFC as I do not have the hardware or documentation. > Perhaps the "bias-disable" property should be dropped instead? This is correct, the ` = <0>` is a downstream style, but it does actually mean to disable the bias afaik, from downstream docs: - bias-disable: Usage: optional Value type: <none> Definition: The specified pins should be configued as no pull. > --- > arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts > index 7747081b98875aad..dba7c2693ff50073 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts > @@ -617,7 +617,7 @@ sde_dsi_active: sde-dsi-active { > pins = "gpio6", "gpio10"; > function = "gpio"; > drive-strength = <8>; > - bias-disable = <0>; > + bias-disable; > }; > > sde_dsi_suspend: sde-dsi-suspend { > -- > 2.25.1 > -- Kind Regards, Caleb
On Fri, 19 Aug 2022 12:14:23 +0200, Geert Uytterhoeven wrote: > "make dtbs_check" says: > > bias-disable: boolean property with value b'\x00\x00\x00\x00' > > Fix this by dropping the offending value. > > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl commit: 5a0504945878b4af7534c1ce668a5678dc0201cf Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts index 7747081b98875aad..dba7c2693ff50073 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts @@ -617,7 +617,7 @@ sde_dsi_active: sde-dsi-active { pins = "gpio6", "gpio10"; function = "gpio"; drive-strength = <8>; - bias-disable = <0>; + bias-disable; }; sde_dsi_suspend: sde-dsi-suspend {
"make dtbs_check" says: bias-disable: boolean property with value b'\x00\x00\x00\x00' Fix this by dropping the offending value. Fixes: be497abe19bf08fb ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Marked RFC as I do not have the hardware or documentation. Perhaps the "bias-disable" property should be dropped instead? --- arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)