| Message ID | 20220825111715.3025694-1-sakari.ailus@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | bd9594ae4c55351f134620ab890259820abf4c43 |
| Headers | show |
| Series | [1/1] acpi: Remove default association from integer maximum values | expand |
On Thu, 25 Aug 2022 at 13:17, Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Remove the default association from integer maximum value checks. It is > not necessary and has caused a bug in other associations being unnoticed. > > Fixes: 923044133367 ("ACPI: property: Unify integer value reading functions") > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > drivers/acpi/property.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > index 91d0e75859d37..d4c168ce428ca 100644 > --- a/drivers/acpi/property.c > +++ b/drivers/acpi/property.c > @@ -1046,8 +1046,7 @@ static int acpi_data_prop_read_single(const struct acpi_device_data *data, > u8 *: U8_MAX, \ > u16 *: U16_MAX, \ > u32 *: U32_MAX, \ > - u64 *: U64_MAX, \ > - default: 0U)) { \ > + u64 *: U64_MAX)) { \ > ret = -EOVERFLOW; \ > break; \ > } \ > -- > 2.30.2 >
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c index 91d0e75859d37..d4c168ce428ca 100644 --- a/drivers/acpi/property.c +++ b/drivers/acpi/property.c @@ -1046,8 +1046,7 @@ static int acpi_data_prop_read_single(const struct acpi_device_data *data, u8 *: U8_MAX, \ u16 *: U16_MAX, \ u32 *: U32_MAX, \ - u64 *: U64_MAX, \ - default: 0U)) { \ + u64 *: U64_MAX)) { \ ret = -EOVERFLOW; \ break; \ } \
Remove the default association from integer maximum value checks. It is not necessary and has caused a bug in other associations being unnoticed. Fixes: 923044133367 ("ACPI: property: Unify integer value reading functions") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/acpi/property.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)