| Message ID | 20220902185148.635292-1-ahalaney@redhat.com |
|---|---|
| Headers | show |
| Series | regulator: dt-bindings: qcom,rpmh: dt-binding fixups | expand |
On Fri, 02 Sep 2022 13:51:46 -0500, Andrew Halaney wrote: > Right now, running make dt_binding_check results in this snippet: > > /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: 'additionalProperties' is a required property > hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > SCHEMA Documentation/devicetree/bindings/processed-schema.json > <snip..> > /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: ignoring, error in schema: > > Which results in the schema not being properly evaluated. Swap out > unevaluatedProperties which doesn't seem to be doing anything for > additionalProperties. > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb: pm8998-rpmh-regulators: 'vdd-l7-l12-l14-l15-supply' does not match any of the regexes: '^(smps|ldo|lvs)[0-9]+$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Fri, Sep 02, 2022 at 01:51:45PM -0500, Andrew Halaney wrote: > Hi, > > This is my poor attempt at getting devicetree validation into a better > state for qcom,rpmh-regulator.yaml. This is a follow-up to Johan's > request for this over here: > > https://lore.kernel.org/linux-arm-msm/Yw8EE%2FESDUnIRf8P@hovoldconsulting.com/ > > In particular, I'm not certain patch 1 is the correct way to handle > things, and patch 2 makes validation too wide for the *-supply nodes. > > I'd love any feedback here as I'm really not experienced in any of the > spaces (regulator, rpmh, or dt schema) so nit picking is welcomed. v2 posted over here: https://lore.kernel.org/linux-arm-msm/20220906201959.69920-1-ahalaney@redhat.com/
Hi, This is my poor attempt at getting devicetree validation into a better state for qcom,rpmh-regulator.yaml. This is a follow-up to Johan's request for this over here: https://lore.kernel.org/linux-arm-msm/Yw8EE%2FESDUnIRf8P@hovoldconsulting.com/ In particular, I'm not certain patch 1 is the correct way to handle things, and patch 2 makes validation too wide for the *-supply nodes. I'd love any feedback here as I'm really not experienced in any of the spaces (regulator, rpmh, or dt schema) so nit picking is welcomed. Thanks in advance, Andrew Andrew Halaney (3): regulator: dt-bindings: qcom,rpmh: Use additionalProperties regulator: dt-bindings: qcom,rpmh: Specify supply property regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies .../bindings/regulator/qcom,rpmh-regulator.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)