diff mbox series

random: use hwgenerator randomness more frequently at early boot

Message ID 20220904101753.3050-1-linux@dominikbrodowski.net
State Accepted
Commit 745558f9588551b1fef9609d165e239bce30d3e8
Headers show
Series random: use hwgenerator randomness more frequently at early boot | expand

Commit Message

Dominik Brodowski Sept. 4, 2022, 10:17 a.m. UTC 
Mix in randomness from hw-rng sources more frequently during early
boot, approximately once for every rng reseed.

Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
---

This patch is currently based on
	[PATCH] random / hw_random: core: start hwrng kthread also for untrusted sources

Jason, if you prefer that this patch can be applied first (as it
makes sense also independently of the other patch), this ordering
should be trivial to change.

 drivers/char/random.c | 32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)

Comments

Jason A. Donenfeld Sept. 7, 2022, 1:02 p.m. UTC | #1 
Hi Dominik,

On Sun, Sep 04, 2022 at 12:17:53PM +0200, Dominik Brodowski wrote:
> Mix in randomness from hw-rng sources more frequently during early
> boot, approximately once for every rng reseed.

Nice idea.

> Jason, if you prefer that this patch can be applied first (as it
> makes sense also independently of the other patch), this ordering
> should be trivial to change.

I'll apply this patch first, yea, since it's independent.

> -static bool crng_has_old_seed(void)
> +static unsigned int crng_interval(void)

crng_reseed_interval() instead?

Jason
Dominik Brodowski Sept. 7, 2022, 1:04 p.m. UTC | #2 
Hi Jason,

Am Wed, Sep 07, 2022 at 03:02:34PM +0200 schrieb Jason A. Donenfeld:
> Hi Dominik,
> 
> On Sun, Sep 04, 2022 at 12:17:53PM +0200, Dominik Brodowski wrote:
> > Mix in randomness from hw-rng sources more frequently during early
> > boot, approximately once for every rng reseed.
> 
> Nice idea.
> 
> > Jason, if you prefer that this patch can be applied first (as it
> > makes sense also independently of the other patch), this ordering
> > should be trivial to change.
> 
> I'll apply this patch first, yea, since it's independent.
> 
> > -static bool crng_has_old_seed(void)
> > +static unsigned int crng_interval(void)
> 
> crng_reseed_interval() instead?

Sounds good. Thanks!

	Dominik
diff mbox series

Patch

diff --git a/drivers/char/random.c b/drivers/char/random.c
index b360ed4ece03..5559351f1259 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -260,25 +260,35 @@  static void crng_fast_key_erasure(u8 key[CHACHA_KEY_SIZE],
 }
 
 /*
- * Return whether the crng seed is considered to be sufficiently old
- * that a reseeding is needed. This happens if the last reseeding
- * was CRNG_RESEED_INTERVAL ago, or during early boot, at an interval
- * proportional to the uptime.
+ * Return the interval to the next regular reseed of the crng. This
+ * equals CRNG_RESEED_INTERVAL, or during early boot, an interval
+ * proportional to the uptime,
  */
-static bool crng_has_old_seed(void)
+static unsigned int crng_interval(void)
 {
 	static bool early_boot = true;
-	unsigned long interval = CRNG_RESEED_INTERVAL;
 
 	if (unlikely(READ_ONCE(early_boot))) {
 		time64_t uptime = ktime_get_seconds();
 		if (uptime >= CRNG_RESEED_INTERVAL / HZ * 2)
 			WRITE_ONCE(early_boot, false);
 		else
-			interval = max_t(unsigned int, CRNG_RESEED_START_INTERVAL,
-					 (unsigned int)uptime / 2 * HZ);
+			return max_t(unsigned int, CRNG_RESEED_START_INTERVAL,
+				     (unsigned int)uptime / 2 * HZ);
 	}
-	return time_is_before_jiffies(READ_ONCE(base_crng.birth) + interval);
+
+	return CRNG_RESEED_INTERVAL;
+}
+
+/*
+ * Return whether the crng seed is considered to be sufficiently old
+ * that a reseeding is needed. This happens if the last reseeding
+ * was CRNG_RESEED_INTERVAL ago, or during early boot, at an interval
+ * proportional to the uptime.
+ */
+static bool crng_has_old_seed(void)
+{
+	return time_is_before_jiffies(READ_ONCE(base_crng.birth) + crng_interval());
 }
 
 /*
@@ -866,11 +876,11 @@  void add_hwgenerator_randomness(const void *buf, size_t len, size_t entropy)
 	credit_init_bits(entropy);
 
 	/*
-	 * Throttle writing to once every CRNG_RESEED_INTERVAL, unless
+	 * Throttle writing to once every reseed interval, unless
 	 * we're not yet initialized or this source isn't trusted.
 	 */
 	if (!kthread_should_stop() && (crng_ready() || !entropy))
-		schedule_timeout_interruptible(CRNG_RESEED_INTERVAL);
+		schedule_timeout_interruptible(crng_interval());
 }
 EXPORT_SYMBOL_GPL(add_hwgenerator_randomness);