| Message ID | 20220914165212.3705892-1-vkoul@kernel.org |
|---|---|
| Headers | show |
| Series | spmi: pmic-arb: Add support for PMIC v7 | expand |
On Thu, Sep 15, 2022 at 10:51:03AM +0100, Krzysztof Kozlowski wrote: > On Wed, 14 Sep 2022 22:22:11 +0530, Vinod Koul wrote: > > For PMIC arbiter version 7 and beyond we need to define if we are using > > primary or secondary bus, so add a new property of qcom,bus-id > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > Acked-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: Unevaluated properties are not allowed ('dma-channels', 'dma-masters', 'dma-requests' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml Ignore this. Unrelated. Rob
On 15-09-22, 06:59, Rob Herring wrote: > On Thu, Sep 15, 2022 at 10:51:03AM +0100, Krzysztof Kozlowski wrote: > > On Wed, 14 Sep 2022 22:22:11 +0530, Vinod Koul wrote: > > > For PMIC arbiter version 7 and beyond we need to define if we are using > > > primary or secondary bus, so add a new property of qcom,bus-id > > > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > > Acked-by: Rob Herring <robh@kernel.org> > > > --- > > > .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: Unevaluated properties are not allowed ('dma-channels', 'dma-masters', 'dma-requests' were unexpected) > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml > > Ignore this. Unrelated. Right!
On 21-09-22, 20:45, Vinod Koul wrote: > On 14-09-22, 22:22, Vinod Koul wrote: > > Hello, > > > > The is version 5 of support for PMIC v7. I have added a new property > > qcom,bus-id for supporting v7 and then add driver changes for v7 > > Steve, > > Can you please get this in for v6.1 ? I dont know what I can do now to get this patch in... looks like 6.1 is missed too! > > > > > Changes since v4: > > - Fix David name and email > > - remove trailing line in binding > > > > Changes since v3: > > - rebase on spmi/next > > > > David Collins (1): > > spmi: pmic-arb: Add support for PMIC v7 > > > > Vinod Koul (1): > > dt-bindings: spmi: Add qcom,bus-id > > > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 10 + > > drivers/spmi/spmi-pmic-arb.c | 242 ++++++++++++++++-- > > 2 files changed, 231 insertions(+), 21 deletions(-) > > > > > > base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a > > -- > > 2.37.3 > > -- > ~Vinod
On 14-09-22, 22:22, Vinod Koul wrote: > Hello, > > The is version 5 of support for PMIC v7. I have added a new property > qcom,bus-id for supporting v7 and then add driver changes for v7 Stephen, Can you pick this? It has been so long... > > Changes since v4: > - Fix David name and email > - remove trailing line in binding > > Changes since v3: > - rebase on spmi/next > > David Collins (1): > spmi: pmic-arb: Add support for PMIC v7 > > Vinod Koul (1): > dt-bindings: spmi: Add qcom,bus-id > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 10 + > drivers/spmi/spmi-pmic-arb.c | 242 ++++++++++++++++-- > 2 files changed, 231 insertions(+), 21 deletions(-) > > > base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a > -- > 2.37.3
On 11/3/2022 9:27 AM, Vinod Koul wrote: > On 14-09-22, 22:22, Vinod Koul wrote: >> Hello, >> >> The is version 5 of support for PMIC v7. I have added a new property >> qcom,bus-id for supporting v7 and then add driver changes for v7 > Stephen, > > Can you pick this? It has been so long... Hi Stephen, Do you mind looking at this? I've got some patches that depend on functionality here... https://lore.kernel.org/all/20221118192241.29384-1-quic_molvera@quicinc.com/ Thanks, Melody >> Changes since v4: >> - Fix David name and email >> - remove trailing line in binding >> >> Changes since v3: >> - rebase on spmi/next >> >> David Collins (1): >> spmi: pmic-arb: Add support for PMIC v7 >> >> Vinod Koul (1): >> dt-bindings: spmi: Add qcom,bus-id >> >> .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 10 + >> drivers/spmi/spmi-pmic-arb.c | 242 ++++++++++++++++-- >> 2 files changed, 231 insertions(+), 21 deletions(-) >> >> >> base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a >> -- >> 2.37.3