mbox series

[v4,0/2] spmi: pmic-arb: Add support for PMIC v7

Message ID 20220914112139.3680354-1-vkoul@kernel.org
Headers show
Series spmi: pmic-arb: Add support for PMIC v7 | expand

Message

Vinod Koul Sept. 14, 2022, 11:21 a.m. UTC 
Hello,

The is version 4 of support for PMIC v7. I have added a new property
qcom,bus-id for supporting v7 and then add driver changes for v7


Changes since v4:
 - rebase on spmi/next

David Dai (1):
  spmi: pmic-arb: Add support for PMIC v7

Vinod Koul (1):
  dt-bindings: spmi: Add qcom,bus-id

 .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  11 +
 drivers/spmi/spmi-pmic-arb.c                  | 242 ++++++++++++++++--
 2 files changed, 232 insertions(+), 21 deletions(-)

Comments

Bjorn Andersson Sept. 14, 2022, 2:11 p.m. UTC | #1 
On Wed, Sep 14, 2022 at 04:51:38PM +0530, Vinod Koul wrote:
> For PMIC arbiter version 7 and beyond we need to define if we are using
> primary or secondary bus, so add a new property of qcom,bus-id
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> index fee4f0eb4665..aa8e891b2bb4 100644
> --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> @@ -85,6 +85,14 @@ properties:
>      description: >
>        which of the PMIC Arb provided channels to use for accesses
>  
> +  qcom,bus-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1
> +    description: >
> +      SPMI bus instance. only applicable to PMIC arbiter version 7 and beyond.
> +      Supported values, 0 = primary bus, 1 = secondary bus
> +
>  required:
>    - compatible
>    - reg-names
> @@ -113,5 +121,8 @@ examples:
>  
>          interrupt-controller;
>          #interrupt-cells = <4>;
> +
> +        qcom,bus-id = <0>;
> +

As you correct the author on patch 2/2, please drop this last empty
line.

Thanks,
Bjorn

>      };
>  
> -- 
> 2.37.3
>