| Message ID | 20220927031929.807070-1-sergio.paracuellos@gmail.com |
|---|---|
| State | Accepted |
| Commit | 048f71f7685706dcc859160cc74f73e361cfe6c0 |
| Headers | show |
| Series | [RESEND,v3] dt-bindings: spi: migrate mt7621 text bindings to YAML | expand |
On Tue, Sep 27, 2022 at 05:19:29AM +0200, Sergio Paracuellos wrote: > SoC MT7621 SPI bindings used text format, so migrate them to YAML. > There are some additions to the binding that were not in the original Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Hi Mark, On Tue, Sep 27, 2022 at 1:12 PM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Sep 27, 2022 at 05:19:29AM +0200, Sergio Paracuellos wrote: > > SoC MT7621 SPI bindings used text format, so migrate them to YAML. > > There are some additions to the binding that were not in the original > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. Since this is a binding migration change I sent the patch expecting this going into the devicetree kernel tree. So I just use the common device tree change style 'dt-bindings: spi: migrate mt7621 text bindings to YAML' as the subject. So I don't really understand what you mean above, sorry. What is wrong with this subject? I submitted this v3 [0] and I was told by Rob to resend it to you and the linux-spi mail list also. Thanks in advance for clarification. Best regards, Sergio Paracuellos [0]: https://lore.kernel.org/linux-devicetree/CAMhs-H-fK=F7Wy7-pti+0SKo8DqyZGWu_g74-5MYLxzBhaihmA@mail.gmail.com/T/#m28f6b6d720a7f4477c1c0e8f49ba8e59ed95d6dc
On Tue, Sep 27, 2022 at 1:59 PM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Sep 27, 2022 at 01:36:04PM +0200, Sergio Paracuellos wrote: > > On Tue, Sep 27, 2022 at 1:12 PM Mark Brown <broonie@kernel.org> wrote: > > > On Tue, Sep 27, 2022 at 05:19:29AM +0200, Sergio Paracuellos wrote: > > > > Please submit patches using subject lines reflecting the style for the > > > subsystem, this makes it easier for people to identify relevant patches. > > > Since this is a binding migration change I sent the patch expecting > > this going into the devicetree kernel tree. So I just use the common > > device tree change style 'dt-bindings: spi: migrate mt7621 text > > bindings to YAML' as the subject. So I don't really understand what > > you mean above, sorry. What is wrong with this subject? I submitted > > this v3 [0] and I was told by Rob to resend it to you and the > > linux-spi mail list also. > > Bindings mostly go through the subsystem rather than the DT tree. I thought when changes are only in the binding side DT tree was preferred. Sorry for the inconvenience, then. Will take into account your advice from now on. Thanks, Sergio Paracuellos
On Tue, 27 Sep 2022 05:19:29 +0200, Sergio Paracuellos wrote: > SoC MT7621 SPI bindings used text format, so migrate them to YAML. > There are some additions to the binding that were not in the original > file. This binding is used in MT7621 and MT7628a Ralink SoCs. To > properly match both dts nodes in tree we need to add to the schema > 'clocks', 'clock-names' and 'reset-names'. Both 'clock-names' and > 'reset-names' use 'spi' as string so maintain that as const in > the schema. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] dt-bindings: spi: migrate mt7621 text bindings to YAML commit: 048f71f7685706dcc859160cc74f73e361cfe6c0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, Sep 27, 2022 at 02:09:21PM +0200, Sergio Paracuellos wrote: > On Tue, Sep 27, 2022 at 1:59 PM Mark Brown <broonie@kernel.org> wrote: > > > > On Tue, Sep 27, 2022 at 01:36:04PM +0200, Sergio Paracuellos wrote: > > > On Tue, Sep 27, 2022 at 1:12 PM Mark Brown <broonie@kernel.org> wrote: > > > > On Tue, Sep 27, 2022 at 05:19:29AM +0200, Sergio Paracuellos wrote: > > > > > > Please submit patches using subject lines reflecting the style for the > > > > subsystem, this makes it easier for people to identify relevant patches. > > > > > Since this is a binding migration change I sent the patch expecting > > > this going into the devicetree kernel tree. So I just use the common > > > device tree change style 'dt-bindings: spi: migrate mt7621 text > > > bindings to YAML' as the subject. So I don't really understand what > > > you mean above, sorry. What is wrong with this subject? I submitted > > > this v3 [0] and I was told by Rob to resend it to you and the > > > linux-spi mail list also. > > > > Bindings mostly go through the subsystem rather than the DT tree. > > I thought when changes are only in the binding side DT tree was > preferred. Sorry for the inconvenience, then. Will take into account > your advice from now on. Sometimes they do, but that's more the exception. The ones from you I've picked up don't have a subsystem really or the subsystem maintainer isn't too active or doesn't pay much attention to DT only patches. Mark is responsive and pays some attention to binding patches, so he takes them. Rob
On Thu, Sep 29, 2022 at 6:48 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Sep 27, 2022 at 02:09:21PM +0200, Sergio Paracuellos wrote: > > On Tue, Sep 27, 2022 at 1:59 PM Mark Brown <broonie@kernel.org> wrote: > > > > > > On Tue, Sep 27, 2022 at 01:36:04PM +0200, Sergio Paracuellos wrote: > > > > On Tue, Sep 27, 2022 at 1:12 PM Mark Brown <broonie@kernel.org> wrote: > > > > > On Tue, Sep 27, 2022 at 05:19:29AM +0200, Sergio Paracuellos wrote: > > > > > > > > Please submit patches using subject lines reflecting the style for the > > > > > subsystem, this makes it easier for people to identify relevant patches. > > > > > > > Since this is a binding migration change I sent the patch expecting > > > > this going into the devicetree kernel tree. So I just use the common > > > > device tree change style 'dt-bindings: spi: migrate mt7621 text > > > > bindings to YAML' as the subject. So I don't really understand what > > > > you mean above, sorry. What is wrong with this subject? I submitted > > > > this v3 [0] and I was told by Rob to resend it to you and the > > > > linux-spi mail list also. > > > > > > Bindings mostly go through the subsystem rather than the DT tree. > > > > I thought when changes are only in the binding side DT tree was > > preferred. Sorry for the inconvenience, then. Will take into account > > your advice from now on. > > Sometimes they do, but that's more the exception. The ones from you I've > picked up don't have a subsystem really or the subsystem maintainer > isn't too active or doesn't pay much attention to DT only patches. Mark > is responsive and pays some attention to binding patches, so he takes > them. Thanks a lot for clarification, Rob. Much appreciated. Best regards, Sergio Paracuellos > > Rob
diff --git a/Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml b/Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml new file mode 100644 index 000000000000..22879f7dcb77 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/ralink,mt7621-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +maintainers: + - Sergio Paracuellos <sergio.paracuellos@gmail.com> + +title: Mediatek MT7621/MT7628 SPI controller + +allOf: + - $ref: /schemas/spi/spi-controller.yaml# + +properties: + compatible: + const: ralink,mt7621-spi + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: spi + + resets: + maxItems: 1 + + reset-names: + const: spi + +required: + - compatible + - reg + - resets + - "#address-cells" + - "#size-cells" + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/mt7621-clk.h> + #include <dt-bindings/reset/mt7621-reset.h> + + spi@b00 { + compatible = "ralink,mt7621-spi"; + reg = <0xb00 0x100>; + clocks = <&sysc MT7621_CLK_SPI>; + clock-names = "spi"; + resets = <&sysc MT7621_RST_SPI>; + reset-names = "spi"; + + #address-cells = <1>; + #size-cells = <0>; + + pinctrl-names = "default"; + pinctrl-0 = <&spi_pins>; + }; diff --git a/Documentation/devicetree/bindings/spi/spi-mt7621.txt b/Documentation/devicetree/bindings/spi/spi-mt7621.txt deleted file mode 100644 index d5baec0fa56e..000000000000 --- a/Documentation/devicetree/bindings/spi/spi-mt7621.txt +++ /dev/null @@ -1,26 +0,0 @@ -Binding for MTK SPI controller (MT7621 MIPS) - -Required properties: -- compatible: Should be one of the following: - - "ralink,mt7621-spi": for mt7621/mt7628/mt7688 platforms -- #address-cells: should be 1. -- #size-cells: should be 0. -- reg: Address and length of the register set for the device -- resets: phandle to the reset controller asserting this device in - reset - See ../reset/reset.txt for details. - -Optional properties: -- cs-gpios: see spi-bus.txt. - -Example: - -- SoC Specific Portion: -spi0: spi@b00 { - compatible = "ralink,mt7621-spi"; - reg = <0xb00 0x100>; - #address-cells = <1>; - #size-cells = <0>; - resets = <&rstctrl 18>; - reset-names = "spi"; -};