| Message ID | 20220928102505.39709-1-n.petrova@fintech.ru |
|---|---|
| State | Accepted |
| Commit | 094528b6a5a755b1195a01e10b13597d67d1a0e6 |
| Headers | show |
| Series | nitrox: avoid double free on error path in nitrox_sriov_init() | expand |
On Wed, Sep 28, 2022 at 01:25:05PM +0300, Natalia Petrova wrote: > If alloc_workqueue() fails in nitrox_mbox_init() it deallocates > ndev->iov.vfdev and returns error code, but then nitrox_sriov_init() > calls nitrox_sriov_cleanup() where ndev->iov.vfdev is deallocated > again. > > Fix this by nulling ndev->iov.vfdev after the first deallocation. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Natalia Petrova <n.petrova@fintech.ru> > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > --- > drivers/crypto/cavium/nitrox/nitrox_mbx.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
diff --git a/drivers/crypto/cavium/nitrox/nitrox_mbx.c b/drivers/crypto/cavium/nitrox/nitrox_mbx.c index 9e7308e39b30..d4e06999af9b 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_mbx.c +++ b/drivers/crypto/cavium/nitrox/nitrox_mbx.c @@ -195,6 +195,7 @@ int nitrox_mbox_init(struct nitrox_device *ndev) ndev->iov.pf2vf_wq = alloc_workqueue("nitrox_pf2vf", 0, 0); if (!ndev->iov.pf2vf_wq) { kfree(ndev->iov.vfdev); + ndev->iov.vfdev = NULL; return -ENOMEM; } /* enable pf2vf mailbox interrupts */