| Message ID | 20221019145600.1282823-15-john.ogness@linutronix.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [printk,v2,01/38] serial: kgdboc: Lock console list in probe function | expand |
On Wed 2022-10-19 17:01:36, John Ogness wrote: > Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). > > Signed-off-by: John Ogness <john.ogness@linutronix.de> > --- > drivers/tty/serial/samsung_tty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 77d1363029f5..8142a0e53ffa 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -1732,7 +1732,7 @@ static void __init s3c24xx_serial_register_console(void) > > static void s3c24xx_serial_unregister_console(void) > { > - if (s3c24xx_serial_console.flags & CON_ENABLED) > + if (console_is_enabled(&s3c24xx_serial_console)) > unregister_console(&s3c24xx_serial_console); > } As on many other locations, it would be better to check if the console is in console_list. CON_ENABLED might be disabled even when the console is registered. It would be nice to fix this. But it might be done later. Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 77d1363029f5..8142a0e53ffa 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1732,7 +1732,7 @@ static void __init s3c24xx_serial_register_console(void) static void s3c24xx_serial_unregister_console(void) { - if (s3c24xx_serial_console.flags & CON_ENABLED) + if (console_is_enabled(&s3c24xx_serial_console)) unregister_console(&s3c24xx_serial_console); }
Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). Signed-off-by: John Ogness <john.ogness@linutronix.de> --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)