| Message ID | 20221121142300.9320-3-rogerq@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | net: ethernet: ti: am65-cpsw: Fix set channel operation | expand |
On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote: > ALE_CLEAR command is issued in cpsw_ale_start() so no need > to issue it before the call to cpsw_ale_start(). > > Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") Not a fix to me, can you send it to -next tree? As you said, it's an optimization. > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > index 505c9edf98ff..2acde5b14516 100644 > --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c > +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > @@ -404,7 +404,6 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common) > /* disable priority elevation */ > writel(0, common->cpsw_base + AM65_CPSW_REG_PTYPE); > > - cpsw_ale_control_set(common->ale, 0, ALE_CLEAR, 1); > cpsw_ale_start(common->ale); > > /* limit to one RX flow only */ > -- > 2.17.1 >
On Mon, Nov 21, 2022 at 06:51:05PM +0100, Maciej Fijalkowski wrote: > On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote: > > ALE_CLEAR command is issued in cpsw_ale_start() so no need > > to issue it before the call to cpsw_ale_start(). > > > > Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") > > Not a fix to me, can you send it to -next tree? As you said, it's an > optimization. commit fd23df72f2be317d38d9fde0a8996b8e7454fd2a Author: Roger Quadros <rogerq@kernel.org> Date: Fri Nov 4 15:23:07 2022 +0200 The change being fixed is in net-next. Roger, please take a look at the netdev FAQ and fix your Subject line. Andrew
On Tue, Nov 22, 2022 at 02:02:29AM +0100, Andrew Lunn wrote: > On Mon, Nov 21, 2022 at 06:51:05PM +0100, Maciej Fijalkowski wrote: > > On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote: > > > ALE_CLEAR command is issued in cpsw_ale_start() so no need > > > to issue it before the call to cpsw_ale_start(). > > > > > > Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") > > > > Not a fix to me, can you send it to -next tree? As you said, it's an > > optimization. > > commit fd23df72f2be317d38d9fde0a8996b8e7454fd2a > Author: Roger Quadros <rogerq@kernel.org> > Date: Fri Nov 4 15:23:07 2022 +0200 > > The change being fixed is in net-next. Ah right, nevertheless I had some comments there. > > Roger, please take a look at the netdev FAQ and fix your Subject line. > > Andrew
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index 505c9edf98ff..2acde5b14516 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -404,7 +404,6 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common) /* disable priority elevation */ writel(0, common->cpsw_base + AM65_CPSW_REG_PTYPE); - cpsw_ale_control_set(common->ale, 0, ALE_CLEAR, 1); cpsw_ale_start(common->ale); /* limit to one RX flow only */
ALE_CLEAR command is issued in cpsw_ale_start() so no need to issue it before the call to cpsw_ale_start(). Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") Signed-off-by: Roger Quadros <rogerq@kernel.org> --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 - 1 file changed, 1 deletion(-)