| Message ID | 20221207151400.1572582-1-alexander.stein@ew.tq-group.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp | expand |
On 12/7/22 16:14, Alexander Stein wrote: > i.MX8MP requires a power-domain for this peripheral to use. Add it as > an optional property. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 793e8eccf8b8b..9d9fb5ad587c2 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -52,6 +52,9 @@ properties: > interrupts: > maxItems: 1 > > + power-domains: > + maxItems: 1 > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: The LCDIF output port Should this be required on mx8mp then ?
On Wed, 07 Dec 2022 16:14:00 +0100, Alexander Stein wrote: > i.MX8MP requires a power-domain for this peripheral to use. Add it as > an optional property. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut: > On 12/7/22 16:14, Alexander Stein wrote: > > i.MX8MP requires a power-domain for this peripheral to use. Add it as > > an optional property. > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index > > 793e8eccf8b8b..9d9fb5ad587c2 100644 > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > > @@ -52,6 +52,9 @@ properties: > > interrupts: > > maxItems: 1 > > > > + power-domains: > > + maxItems: 1 > > + > > > > port: > > $ref: /schemas/graph.yaml#/properties/port > > description: The LCDIF output port > > Should this be required on mx8mp then ? I'm hesitating to add a required property later on. But I'm okay with both. Rob, Krzysztof: Any preference here? Shall power-domains be made required for fsl,imx8mp-lcdif only? Best regards, Alexander
Hello Marek, Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut: > On 12/7/22 16:13, Alexander Stein wrote: > > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & > > clock-names. > > > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index > > 876015a44a1e6..793e8eccf8b8b 100644 > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > > @@ -70,7 +70,9 @@ allOf: > > properties: > > compatible: > > contains: > > - const: fsl,imx6sx-lcdif > > + enum: > > + - fsl,imx6sx-lcdif > > + - fsl,imx8mp-lcdif > > > > then: > > properties: > > clocks: > Reviewed-by: Marek Vasut <marex@denx.de> Thanks! > btw you might want to update the clock-names and clock proerty order in > imx8mp.dtsi to match the clock-names order in these bindings. The lcdif nodes are not yet in linux-next ;-) So its probably a local commit on your side. But yes, the upcoming patches will address this. Best regards, Alexander
On 08/12/2022 06:59, Alexander Stein wrote: > Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut: >> On 12/7/22 16:14, Alexander Stein wrote: >>> i.MX8MP requires a power-domain for this peripheral to use. Add it as >>> an optional property. >>> >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> --- >>> >>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index >>> 793e8eccf8b8b..9d9fb5ad587c2 100644 >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> >>> @@ -52,6 +52,9 @@ properties: >>> interrupts: >>> maxItems: 1 >>> >>> + power-domains: >>> + maxItems: 1 >>> + >>> >>> port: >>> $ref: /schemas/graph.yaml#/properties/port >>> description: The LCDIF output port >> >> Should this be required on mx8mp then ? > > I'm hesitating to add a required property later on. But I'm okay with both. > Rob, Krzysztof: Any preference here? Shall power-domains be made required for > fsl,imx8mp-lcdif only? I don't know. That's not the question to us, but to someone who knows the hardware/datasheet. Best regards, Krzysztof
Hello Krzysztof, Am Donnerstag, 8. Dezember 2022, 09:25:31 CET schrieb Krzysztof Kozlowski: > On 08/12/2022 06:59, Alexander Stein wrote: > > Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut: > >> On 12/7/22 16:14, Alexander Stein wrote: > >>> i.MX8MP requires a power-domain for this peripheral to use. Add it as > >>> an optional property. > >>> > >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > >>> --- > >>> > >>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > >>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index > >>> 793e8eccf8b8b..9d9fb5ad587c2 100644 > >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > >>> > >>> @@ -52,6 +52,9 @@ properties: > >>> interrupts: > >>> maxItems: 1 > >>> > >>> + power-domains: > >>> + maxItems: 1 > >>> + > >>> > >>> port: > >>> $ref: /schemas/graph.yaml#/properties/port > >>> description: The LCDIF output port > >> > >> Should this be required on mx8mp then ? > > > > I'm hesitating to add a required property later on. But I'm okay with > > both. > > Rob, Krzysztof: Any preference here? Shall power-domains be made required > > for fsl,imx8mp-lcdif only? > > I don't know. That's not the question to us, but to someone who knows > the hardware/datasheet. I was not talking about the hardware, which needs the power-domain, but the DT schema. Sorry to be not specific about this. Is it okay to add a required property for a compatible later on? Best regards, Alexander
On 08/12/2022 09:50, Alexander Stein wrote: > Hello Krzysztof, > > Am Donnerstag, 8. Dezember 2022, 09:25:31 CET schrieb Krzysztof Kozlowski: >> On 08/12/2022 06:59, Alexander Stein wrote: >>> Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut: >>>> On 12/7/22 16:14, Alexander Stein wrote: >>>>> i.MX8MP requires a power-domain for this peripheral to use. Add it as >>>>> an optional property. >>>>> >>>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>>>> --- >>>>> >>>>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index >>>>> 793e8eccf8b8b..9d9fb5ad587c2 100644 >>>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>>>> >>>>> @@ -52,6 +52,9 @@ properties: >>>>> interrupts: >>>>> maxItems: 1 >>>>> >>>>> + power-domains: >>>>> + maxItems: 1 >>>>> + >>>>> >>>>> port: >>>>> $ref: /schemas/graph.yaml#/properties/port >>>>> description: The LCDIF output port >>>> >>>> Should this be required on mx8mp then ? >>> >>> I'm hesitating to add a required property later on. But I'm okay with >>> both. >>> Rob, Krzysztof: Any preference here? Shall power-domains be made required >>> for fsl,imx8mp-lcdif only? >> >> I don't know. That's not the question to us, but to someone who knows >> the hardware/datasheet. > > I was not talking about the hardware, which needs the power-domain, but the DT > schema. Sorry to be not specific about this. > Is it okay to add a required property for a compatible later on? Yes, it is okay, assuming: 1. Linux implementation still works without it thus preserving ABI. 2. It is really required, e.g. device cannot operate without it (your commit msg suggests that). 3. The property should be required since beginning, but we did not add it due to mistake/forgot/lack of docs etc. Best regards, Krzysztof
On 12/8/22 07:31, Alexander Stein wrote: > Hello Marek, > > Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut: >> On 12/7/22 16:13, Alexander Stein wrote: >>> i.MX8MP uses 3 clocks, so soften the restrictions for clocks & >>> clock-names. >>> >>> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> --- >>> >>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index >>> 876015a44a1e6..793e8eccf8b8b 100644 >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> >>> @@ -70,7 +70,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: fsl,imx6sx-lcdif >>> + enum: >>> + - fsl,imx6sx-lcdif >>> + - fsl,imx8mp-lcdif >>> >>> then: >>> properties: >>> clocks: >> Reviewed-by: Marek Vasut <marex@denx.de> > > Thanks! > >> btw you might want to update the clock-names and clock proerty order in >> imx8mp.dtsi to match the clock-names order in these bindings. > > The lcdif nodes are not yet in linux-next ;-) So its probably a local commit > on your side. But yes, the upcoming patches will address this. Ah, right, seems they are still pending HDMI and DSIM addition. Sorry for the noise.
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 876015a44a1e6..793e8eccf8b8b 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -70,7 +70,9 @@ allOf: properties: compatible: contains: - const: fsl,imx6sx-lcdif + enum: + - fsl,imx6sx-lcdif + - fsl,imx8mp-lcdif then: properties: clocks:
i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)