| Message ID | 20221208142006.425809-1-paul.kocialkowski@bootlin.com |
|---|---|
| Headers | show |
| Series | Allwinner A31/A83T CSI/ISP/MIPI CSI-2 media fixes | expand |
On Thu, 08 Dec 2022 06:19:54 PST (-0800), paul.kocialkowski@bootlin.com wrote: > This series resolves reported smatch warnings against the recently-introduced > Allwinner A31/A83T CSI, ISP and MIPI CSI-2 drivers. > > Smatch was ran again on the updated tree and no longer shows any error or > warning. Thanks. These also fix a handful of warnings I'm seeing when building with clang. Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> > Changes since v2: > - Added isp params pending buffer fix; > - Added fixes tags where needed; > - Reworded cosmetic commits; > - Changed sunxi-isp to the proper sun6i-isp. > > Changes since v1: > - Added fixes for static struct declarations; > - Fixed ISP commit titles by replacing bridge with proc. > > Paul > > Paul Kocialkowski (12): > media: sun6i-csi: bridge: Fix return code handling in stream off path > media: sun6i-csi: bridge: Error out on invalid port to fix warning > media: sunxi-csi: bridge: Declare subdev ops as static > media: sun6i-csi: capture: Remove useless ret initialization > media: sun6i-mipi-csi2: Clarify return code handling in stream off > path > media: sun8i-a83t-mipi-csi2: Clarify return code handling in stream > off path > media: sun6i-isp: proc: Fix return code handling in stream off path > media: sun6i-isp: proc: Error out on invalid port to fix warning > media: sun6i-isp: proc: Declare subdev ops as static > media: sun6i-isp: capture: Fix uninitialized variable use > media: sun6i-isp: params: Fix incorrect indentation > media: sun6i-isp: params: Unregister pending buffer on cleanup > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c | 8 ++++---- > .../media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +- > .../platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 5 ++--- > .../sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c | 5 ++--- > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c | 4 ++-- > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c | 6 ++++-- > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 8 ++++---- > 7 files changed, 19 insertions(+), 19 deletions(-)
This series resolves reported smatch warnings against the recently-introduced Allwinner A31/A83T CSI, ISP and MIPI CSI-2 drivers. Smatch was ran again on the updated tree and no longer shows any error or warning. Changes since v2: - Added isp params pending buffer fix; - Added fixes tags where needed; - Reworded cosmetic commits; - Changed sunxi-isp to the proper sun6i-isp. Changes since v1: - Added fixes for static struct declarations; - Fixed ISP commit titles by replacing bridge with proc. Paul Paul Kocialkowski (12): media: sun6i-csi: bridge: Fix return code handling in stream off path media: sun6i-csi: bridge: Error out on invalid port to fix warning media: sunxi-csi: bridge: Declare subdev ops as static media: sun6i-csi: capture: Remove useless ret initialization media: sun6i-mipi-csi2: Clarify return code handling in stream off path media: sun8i-a83t-mipi-csi2: Clarify return code handling in stream off path media: sun6i-isp: proc: Fix return code handling in stream off path media: sun6i-isp: proc: Error out on invalid port to fix warning media: sun6i-isp: proc: Declare subdev ops as static media: sun6i-isp: capture: Fix uninitialized variable use media: sun6i-isp: params: Fix incorrect indentation media: sun6i-isp: params: Unregister pending buffer on cleanup drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c | 8 ++++---- .../media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +- .../platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 5 ++--- .../sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c | 5 ++--- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c | 4 ++-- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c | 6 ++++-- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 8 ++++---- 7 files changed, 19 insertions(+), 19 deletions(-)