| Message ID | 20230103045613.100309-1-p.rajanbabu@samsung.com |
|---|---|
| Headers | show |
| Series | ASoC: samsung: fsd: audio support for FSD SoC | expand |
On 03/01/2023 05:56, Padmanabhan Rajanbabu wrote: > Add device tree node support for codec on Tesla FSD platform. > > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> > --- > arch/arm64/boot/dts/tesla/fsd-evb.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts > index cf5f2ce4d2a7..e2fd49774f15 100644 > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts > @@ -10,6 +10,7 @@ > > /dts-v1/; > #include "fsd.dtsi" > +#include <dt-bindings/gpio/gpio.h> > > / { > model = "Tesla Full Self-Driving (FSD) Evaluation board"; > @@ -34,6 +35,18 @@ > clock-frequency = <24000000>; > }; > > +&hsi2c_5 { > + status = "okay"; > + > + tlv320aic3x: codec@18 { > + #sound-dai-cells = <0>; > + compatible = "ti,tlv320aic3104"; > + reg = <0x18>; First compatible, then reg, then the rest. > + reset-gpios = <&gpg1 6 GPIO_ACTIVE_LOW>; > + status = "okay"; It's by default. Why do you need it? Best regards, Krzysztof
On Tue, Jan 03, 2023 at 10:26:09AM +0530, Padmanabhan Rajanbabu wrote: > + > + tesla,fsd-i2s: with all the available features of Exynos7 I2S, > + supporting only stereo channel playback and capture. The driver claims that 7.1 is also supported.
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 03 January 2023 04:41 PM > To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>; > lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com; > perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com; > alim.akhtar@samsung.com; rcsekar@samsung.com; > aswani.reddy@samsung.com > Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org > Subject: Re: [PATCH v2 4/5] arm64: dts: fsd: Add codec node for Tesla FSD > > On 03/01/2023 05:56, Padmanabhan Rajanbabu wrote: > > Add device tree node support for codec on Tesla FSD platform. > > > > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> > > --- > > arch/arm64/boot/dts/tesla/fsd-evb.dts | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts > > b/arch/arm64/boot/dts/tesla/fsd-evb.dts > > index cf5f2ce4d2a7..e2fd49774f15 100644 > > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts > > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts > > @@ -10,6 +10,7 @@ > > > > /dts-v1/; > > #include "fsd.dtsi" > > +#include <dt-bindings/gpio/gpio.h> > > > > / { > > model = "Tesla Full Self-Driving (FSD) Evaluation board"; @@ -34,6 > > +35,18 @@ > > clock-frequency = <24000000>; > > }; > > > > +&hsi2c_5 { > > + status = "okay"; > > + > > + tlv320aic3x: codec@18 { > > + #sound-dai-cells = <0>; > > + compatible = "ti,tlv320aic3104"; > > + reg = <0x18>; > > First compatible, then reg, then the rest. Okay, I'll update the same in the next patch set. > > > + reset-gpios = <&gpg1 6 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > It's by default. Why do you need it? Okay, I understood that if there is no status entry, it is treated as "okay". I'll update the same in the next patch set. > > Best regards, > Krzysztof Thanks, Padmanabhan R.
> -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: 03 January 2023 11:35 PM > To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> > Cc: lgirdwood@gmail.com; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com; > perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com; > alim.akhtar@samsung.com; rcsekar@samsung.com; > aswani.reddy@samsung.com; alsa-devel@alsa-project.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-samsung- > soc@vger.kernel.org > Subject: Re: [PATCH v2 1/5] ASoC: dt-bindings: Add FSD I2S controller > bindings > > On Tue, Jan 03, 2023 at 10:26:09AM +0530, Padmanabhan Rajanbabu wrote: > > > + > > + tesla,fsd-i2s: with all the available features of Exynos7 I2S, > > + supporting only stereo channel playback and capture. > > The driver claims that 7.1 is also supported. For I2S mode, data lines for channel 3 to 6 are not routed out of the SoC. i.e FSD SoC has only SDO0 line routed out. SDO1 and 2 are floating pins. So Exynos7-I2S in FSD SoC supports only stereo playback and capture in I2S mode. I'll reword the description in the next patch set to reflect the above information. Thanks, Padmanabhan R.