mbox series

[00/13] hw/arm: Cleanups before pflash refactor

Message ID 20230109115316.2235-1-philmd@linaro.org
Headers show
Series hw/arm: Cleanups before pflash refactor | expand

Message

Philippe Mathieu-Daudé Jan. 9, 2023, 11:53 a.m. UTC 
Various trivial cleanups:
- Remove unnecessary sysmem argument from pxa2xx_init()
- Use IEC binary prefix definitions
- Remove unreachable code calling pflash_cfi01_register()
  (another use in PPC sam460ex will be removed separately).

Philippe Mathieu-Daudé (13):
  hw/arm/pxa2xx: Simplify pxa255_init()
  hw/arm/pxa2xx: Simplify pxa270_init()
  hw/arm/collie: Use the IEC binary prefix definitions
  hw/arm/collie: Simplify flash creation using for() loop
  hw/arm/gumstix: Improve documentation
  hw/arm/gumstix: Use the IEC binary prefix definitions
  hw/arm/mainstone: Use the IEC binary prefix definitions
  hw/arm/musicpal: Use the IEC binary prefix definitions
  hw/arm/omap_sx1: Remove unused 'total_ram' definitions
  hw/arm/omap_sx1: Use the IEC binary prefix definitions
  hw/arm/z2: Use the IEC binary prefix definitions
  hw/arm/vexpress: Remove dead code in vexpress_common_init()
  hw/arm: Remove unreachable code calling pflash_cfi01_register()

 hw/arm/collie.c      | 25 +++++++++++-----------
 hw/arm/gumstix.c     | 45 +++++++++++++++++---------------------
 hw/arm/mainstone.c   | 37 +++++++++++++++-----------------
 hw/arm/musicpal.c    |  9 +++++---
 hw/arm/omap_sx1.c    | 51 +++++++++++++++++++-------------------------
 hw/arm/pxa2xx.c      |  8 ++++---
 hw/arm/spitz.c       |  6 ++----
 hw/arm/tosa.c        |  2 +-
 hw/arm/versatilepb.c |  6 ++----
 hw/arm/vexpress.c    | 10 +--------
 hw/arm/z2.c          | 16 ++++++--------
 include/hw/arm/pxa.h |  5 ++---
 12 files changed, 98 insertions(+), 122 deletions(-)

Comments

Richard Henderson Jan. 9, 2023, 5:40 p.m. UTC | #1 
On 1/9/23 03:53, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (13):
>    hw/arm/pxa2xx: Simplify pxa255_init()
>    hw/arm/pxa2xx: Simplify pxa270_init()
>    hw/arm/collie: Use the IEC binary prefix definitions
>    hw/arm/collie: Simplify flash creation using for() loop
>    hw/arm/gumstix: Improve documentation
>    hw/arm/gumstix: Use the IEC binary prefix definitions
>    hw/arm/mainstone: Use the IEC binary prefix definitions
>    hw/arm/musicpal: Use the IEC binary prefix definitions
>    hw/arm/omap_sx1: Remove unused 'total_ram' definitions
>    hw/arm/omap_sx1: Use the IEC binary prefix definitions
>    hw/arm/z2: Use the IEC binary prefix definitions
>    hw/arm/vexpress: Remove dead code in vexpress_common_init()
>    hw/arm: Remove unreachable code calling pflash_cfi01_register()

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Peter Maydell Jan. 12, 2023, 5:04 p.m. UTC | #2 
On Mon, 9 Jan 2023 at 11:53, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Various trivial cleanups:
> - Remove unnecessary sysmem argument from pxa2xx_init()
> - Use IEC binary prefix definitions
> - Remove unreachable code calling pflash_cfi01_register()
>   (another use in PPC sam460ex will be removed separately).
>



Applied to target-arm.next, thanks.

-- PMM