| Message ID | 20230111211350.1461860-2-martin.blumenstingl@googlemail.com |
|---|---|
| State | Accepted |
| Commit | f95acdb2b4af21caae2c76a48e565158181386ca |
| Headers | show |
| Series | [v2,1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node | expand |
On 11/01/2023 22:13, Martin Blumenstingl wrote: > Unit addresses should be written using lower-case hex characters. Use > wifi_mac@c to fix a yaml schema validation error once the eFuse > dt-bindings have been converted to a yaml schema: > efuse: Unevaluated properties are not allowed ('wifi_mac@C' was > unexpected) > > Also node names should use hyphens instead of underscores as the latter > can also cause warnings. > > Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1") > Acked-by: Vyacheslav Bocharov <adeep@lexina.in> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > changes from v1 -> v2: > - Added Vyacheslav's Acked-by (originally given as "Vyachesav", but my > understanding is that this was a typo > - Also replace the underscore in the node name with a hyphen > > .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > index 6831137c5c10..270483e007bc 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 { > reg = <0x6 0x6>; > }; > > - wifi_mac: wifi_mac@C { > + wifi_mac: wifi-mac@c { > reg = <0xc 0x6>; > }; > }; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts index 6831137c5c10..270483e007bc 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 { reg = <0x6 0x6>; }; - wifi_mac: wifi_mac@C { + wifi_mac: wifi-mac@c { reg = <0xc 0x6>; }; };
Unit addresses should be written using lower-case hex characters. Use wifi_mac@c to fix a yaml schema validation error once the eFuse dt-bindings have been converted to a yaml schema: efuse: Unevaluated properties are not allowed ('wifi_mac@C' was unexpected) Also node names should use hyphens instead of underscores as the latter can also cause warnings. Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1") Acked-by: Vyacheslav Bocharov <adeep@lexina.in> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- changes from v1 -> v2: - Added Vyacheslav's Acked-by (originally given as "Vyachesav", but my understanding is that this was a typo - Also replace the underscore in the node name with a hyphen .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)