| Message ID | 20230111085016.44551-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | hw/i2c/bitbang_i2c: Housekeeping | expand |
On Wed, Jan 11, 2023 at 09:50:11AM +0100, Philippe Mathieu-Daudé wrote: > Series fully reviewed. These all look good to me Acked-by: Corey Minyard <cminyard@mvista.com> You mentioned the ARM tree, is this going in through there? -corey > > Since v2: > - Use array of const pointers to const (Richard) > > Since v1: > - Fixed overwritten RECEIVING_BIT7 entry (Richard) > - Picked R-b tags > > - Remove unused dummy MemoryRegion > - Convert DPRINTF() to using trace events > > (series used as base for follow-up, better if merged via ARM tree) > > Philippe Mathieu-Daudé (5): > hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header > hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion > hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() > helper > hw/i2c/bitbang_i2c: Trace state changes > hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events > > hw/arm/musicpal.c | 3 +- > hw/i2c/bitbang_i2c.c | 80 ++++++++++++++++++++++-------------- > hw/i2c/trace-events | 7 ++++ > include/hw/i2c/bitbang_i2c.h | 2 + > 4 files changed, 61 insertions(+), 31 deletions(-) > > -- > 2.38.1 > >
Le 11/01/2023 à 09:50, Philippe Mathieu-Daudé a écrit : > Series fully reviewed. > > Since v2: > - Use array of const pointers to const (Richard) > > Since v1: > - Fixed overwritten RECEIVING_BIT7 entry (Richard) > - Picked R-b tags > > - Remove unused dummy MemoryRegion > - Convert DPRINTF() to using trace events > > (series used as base for follow-up, better if merged via ARM tree) I can take this via trivial, what do you prefer? Laurent > > Philippe Mathieu-Daudé (5): > hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header > hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion > hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() > helper > hw/i2c/bitbang_i2c: Trace state changes > hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events > > hw/arm/musicpal.c | 3 +- > hw/i2c/bitbang_i2c.c | 80 ++++++++++++++++++++++-------------- > hw/i2c/trace-events | 7 ++++ > include/hw/i2c/bitbang_i2c.h | 2 + > 4 files changed, 61 insertions(+), 31 deletions(-) >
On Mon, 16 Jan 2023 at 17:30, Laurent Vivier <laurent@vivier.eu> wrote: > > Le 11/01/2023 à 09:50, Philippe Mathieu-Daudé a écrit : > > Series fully reviewed. > > > > Since v2: > > - Use array of const pointers to const (Richard) > > > > Since v1: > > - Fixed overwritten RECEIVING_BIT7 entry (Richard) > > - Picked R-b tags > > > > - Remove unused dummy MemoryRegion > > - Convert DPRINTF() to using trace events > > > > (series used as base for follow-up, better if merged via ARM tree) > > I can take this via trivial, what do you prefer? I'm putting together a target-arm pullreq, so I'll take this. thanks -- PMM
Series fully reviewed. Since v2: - Use array of const pointers to const (Richard) Since v1: - Fixed overwritten RECEIVING_BIT7 entry (Richard) - Picked R-b tags - Remove unused dummy MemoryRegion - Convert DPRINTF() to using trace events (series used as base for follow-up, better if merged via ARM tree) Philippe Mathieu-Daudé (5): hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() helper hw/i2c/bitbang_i2c: Trace state changes hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events hw/arm/musicpal.c | 3 +- hw/i2c/bitbang_i2c.c | 80 ++++++++++++++++++++++-------------- hw/i2c/trace-events | 7 ++++ include/hw/i2c/bitbang_i2c.h | 2 + 4 files changed, 61 insertions(+), 31 deletions(-)