diff mbox series

ASoC: amd: ps: Make acp63_fill_platform_dev_info static

Message ID 20230106023116.117404-1-jiapeng.chong@linux.alibaba.com
State New
Headers show
Series ASoC: amd: ps: Make acp63_fill_platform_dev_info static | expand

Commit Message

Jiapeng Chong Jan. 6, 2023, 2:31 a.m. UTC 
This symbol is not used outside of pci-ps.c, so marks it static.

sound/soc/amd/ps/pci-ps.c:170:6: warning: no previous prototype for ‘acp63_fill_platform_dev_info’.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3640
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 sound/soc/amd/ps/pci-ps.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Mark Brown Jan. 23, 2023, 1:30 p.m. UTC | #1 
On Fri, Jan 06, 2023 at 10:31:16AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of pci-ps.c, so marks it static.
> 
> sound/soc/amd/ps/pci-ps.c:170:6: warning: no previous prototype for ‘acp63_fill_platform_dev_info’.

This doesn't apply against current code, please check and resend.
diff mbox series

Patch

diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 401cfd0036be..570736e1b5e8 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -167,10 +167,10 @@  static void get_acp63_device_config(u32 config, struct pci_dev *pci,
 	}
 }
 
-void acp63_fill_platform_dev_info(struct platform_device_info *pdevinfo, struct device *parent,
-				  struct fwnode_handle *fw_node, char *name, unsigned int id,
-				  const struct resource *res, unsigned int num_res,
-				  const void *data, size_t size_data)
+static void acp63_fill_platform_dev_info(struct platform_device_info *pdevinfo,
+					 struct device *parent, struct fwnode_handle *fw_node,
+					 char *name, unsigned int id, const struct resource *res,
+					 unsigned int num_res, const void *data, size_t size_data)
 {
 	pdevinfo->name = name;
 	pdevinfo->id = id;