diff mbox series

[04/11] ARM: dts: exynos: align pin node names in Exynos4412

Message ID 20230120155404.323386-5-krzysztof.kozlowski@linaro.org
State New
Headers show
Series ARM: dts: exynos: DT schema fixes | expand

Commit Message

Krzysztof Kozlowski Jan. 20, 2023, 3:53 p.m. UTC
The DT schema expect pin configuration nodes to have pin prefix or
suffix:

  exynos4412-trats2.dtb: pinctrl@3860000: sleep-state: 'gpz-0', 'gpz-1', 'gpz-2', 'gpz-3', 'gpz-4', 'gpz-5', 'gpz-6'
    do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alim Akhtar Jan. 28, 2023, 4:37 a.m. UTC | #1
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; Inki Dae <inki.dae@samsung.com>; Kyungmin
> Park <kyungmin.park@samsung.com>; Kukjin Kim <kgene@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: replicant@osuosl.org; phone-devel@vger.kernel.org;
> ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker
> <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 04/11] ARM: dts: exynos: align pin node names in
> Exynos4412
> 
> The DT schema expect pin configuration nodes to have pin prefix or
> suffix:
> 
>   exynos4412-trats2.dtb: pinctrl@3860000: sleep-state: 'gpz-0', 'gpz-1', 'gpz-2',
> 'gpz-3', 'gpz-4', 'gpz-5', 'gpz-6'
>     do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$',
> 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> index 58847d4fa846..8ab31c3daa48 100644
> --- a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
> @@ -12,7 +12,7 @@
>  #include "exynos-pinctrl.h"
> 
>  #define PIN_SLP(_pin, _mode, _pull)					\
> -	_pin {								\
> +	pin- ## _pin {							\
>  		samsung,pins = #_pin;					\
>  		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_ ##_mode>;
> 	\
>  		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_ ##_pull>;
> 	\
> --
> 2.34.1
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
index 58847d4fa846..8ab31c3daa48 100644
--- a/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4412-pinctrl.dtsi
@@ -12,7 +12,7 @@ 
 #include "exynos-pinctrl.h"
 
 #define PIN_SLP(_pin, _mode, _pull)					\
-	_pin {								\
+	pin- ## _pin {							\
 		samsung,pins = #_pin;					\
 		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_ ##_mode>;	\
 		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_ ##_pull>;	\