diff mbox series

[v2,1/2] dt-bindings: sram: qcom,imem: document sm8450

Message ID 1676986616-21378-1-git-send-email-quic_mojha@quicinc.com
State Accepted
Commit 64d666a7bd85c6208bb7f6700b426ac8943a7fa3
Headers show
Series [v2,1/2] dt-bindings: sram: qcom,imem: document sm8450 | expand

Commit Message

Mukesh Ojha Feb. 21, 2023, 1:36 p.m. UTC
Add compatible for sm8450 IMEM.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
  - Added Acked-by .

 Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) Feb. 21, 2023, 3:35 p.m. UTC | #1
On Tue, 21 Feb 2023 19:06:55 +0530, Mukesh Ojha wrote:
> Add compatible for sm8450 IMEM.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes in v2:
>   - Added Acked-by .
> 
>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied, thanks!
Konrad Dybcio Feb. 21, 2023, 5:47 p.m. UTC | #2
On 21.02.2023 14:36, Mukesh Ojha wrote:
> Add a simple-mfd representing IMEM on SM8450 and define the PIL
> relocation info region, so that post mortem tools will be able
> to locate the loaded remoteprocs.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Changes in v2:
>  -  put ranges after regs and corrected the sram node position.
> 
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 1a744a3..2a4f4ac 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3814,6 +3814,20 @@
>  			};
>  		};
>  
> +		sram@146aa000 {
Looks like it's not sorted properly? Should be between
TLMM and apss_smmu address-wise.

Konrad
> +			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
> +			reg = <0 0x146aa000 0 0x1000>;
> +			ranges = <0 0 0x146aa000 0x1000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			pil-reloc@94c {
> +				compatible = "qcom,pil-reloc-info";
> +				reg = <0x94c 0xc8>;
> +			};
> +		};
> +
>  		timer@17420000 {
>  			compatible = "arm,armv7-timer-mem";
>  			#address-cells = <1>;
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index 665c06e..ba694ce 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -26,6 +26,7 @@  properties:
           - qcom,sdm845-imem
           - qcom,sdx55-imem
           - qcom,sdx65-imem
+          - qcom,sm8450-imem
       - const: syscon
       - const: simple-mfd