| Message ID | 20230222203847.2664903-2-colin.foster@in-advantage.com |
|---|---|
| State | New |
| Headers | show |
| Series | add support for Phytec PCM-049 and PCM-959 | expand |
On Wed, Feb 22, 2023 at 12:38:46PM -0800, Colin Foster wrote: > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > the Phytec PCM-959 development kit. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > --- > > v4 > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > --- > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml > > diff --git a/Documentation/devicetree/bindings/arm/ti,omap.yaml b/Documentation/devicetree/bindings/arm/ti,omap.yaml > new file mode 100644 > index 000000000000..9c0e08f74fee > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ti,omap.yaml > @@ -0,0 +1,29 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/ti,omap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments OMAP SoC architecture > + > +maintainers: > + - Tony Lindgren <tony@atomide.com> > + > +description: > + Platforms based on Texas Instruments OMAP SoC architecture. > + > +properties: > + $nodename: > + const: '/' > + compatibnle: Oops. Caught this typo too late. I can wait until after the merge window or resend next week. There's probably other feedback. > + oneOf: > + > + - description: TI OMAP 4460 SoC based platforms > + items: > + - enum: > + - phytec,pcm049 # Phytec OMAP 4460 SoM > + - phytec,pcm959 # Phytec development board for the pcm049 > + - const: ti,omap4460 > + - const: ti,omap4 > + > +additionalProperties: true > -- > 2.25.1 >
On 2/22/23 2:38 PM, Colin Foster wrote: > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > the Phytec PCM-959 development kit. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > --- > > v4 > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > --- > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml How will this work if I add the same file? Why not take my WIP patch, make the suggested changes from Rob, then have it as your first patch in this series? Andrew > > diff --git a/Documentation/devicetree/bindings/arm/ti,omap.yaml b/Documentation/devicetree/bindings/arm/ti,omap.yaml > new file mode 100644 > index 000000000000..9c0e08f74fee > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ti,omap.yaml > @@ -0,0 +1,29 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/ti,omap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments OMAP SoC architecture > + > +maintainers: > + - Tony Lindgren <tony@atomide.com> > + > +description: > + Platforms based on Texas Instruments OMAP SoC architecture. > + > +properties: > + $nodename: > + const: '/' > + compatibnle: > + oneOf: > + > + - description: TI OMAP 4460 SoC based platforms > + items: > + - enum: > + - phytec,pcm049 # Phytec OMAP 4460 SoM > + - phytec,pcm959 # Phytec development board for the pcm049 > + - const: ti,omap4460 > + - const: ti,omap4 > + > +additionalProperties: true
On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: > On 2/22/23 2:38 PM, Colin Foster wrote: > > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > > the Phytec PCM-959 development kit. > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > --- > > > > v4 > > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > > > --- > > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml > > How will this work if I add the same file? Why not take my WIP patch, make > the suggested changes from Rob, then have it as your first patch in this > series? Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk off devices one at a time? If the former, when your patch is done it should be a pretty simple rebase conflict resolution. If the latter (which feels more digestable) this offers that template. This was Rob's / Tony's suggestion, albeit before you sent your patch set. Anyway, I'm happy to do any of the following: 1. Take Andrew's patches, add these references and re-submit. 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done it should be an easy rebase before submission. 3. Wait for Andrew's WIP to be done, then submit with this update. I'd like to avoid #3 because I don't know where this might fall on your priorities list.
On 2/23/23 10:25 AM, Colin Foster wrote: > On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: >> On 2/22/23 2:38 PM, Colin Foster wrote: >>> Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and >>> the Phytec PCM-959 development kit. >>> >>> Signed-off-by: Colin Foster <colin.foster@in-advantage.com> >>> --- >>> >>> v4 >>> * New patch, based on a WIP from Andrew Davis <afd@ti.com> >>> >>> --- >>> .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml >> >> How will this work if I add the same file? Why not take my WIP patch, make >> the suggested changes from Rob, then have it as your first patch in this >> series? > > Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk > off devices one at a time? > > If the former, when your patch is done it should be a pretty simple > rebase conflict resolution. If the latter (which feels more digestable) > this offers that template. This was Rob's / Tony's suggestion, albeit > before you sent your patch set. > > > Anyway, I'm happy to do any of the following: > > 1. Take Andrew's patches, add these references and re-submit. > 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done > it should be an easy rebase before submission. > 3. Wait for Andrew's WIP to be done, then submit with this update. > > > I'd like to avoid #3 because I don't know where this might fall on your > priorities list. Low priority for me, I'd suggest #1 or they probably will not be converted anytime soon. Andrew
On Thu, Feb 23, 2023 at 08:25:08AM -0800, Colin Foster wrote: > On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: > > On 2/22/23 2:38 PM, Colin Foster wrote: > > > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > > > the Phytec PCM-959 development kit. > > > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > > --- > > > > > > v4 > > > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > > > > > --- > > > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml > > > > How will this work if I add the same file? Why not take my WIP patch, make > > the suggested changes from Rob, then have it as your first patch in this > > series? > > Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk > off devices one at a time? > > If the former, when your patch is done it should be a pretty simple > rebase conflict resolution. If the latter (which feels more digestable) > this offers that template. This was Rob's / Tony's suggestion, albeit > before you sent your patch set. > > > Anyway, I'm happy to do any of the following: > > 1. Take Andrew's patches, add these references and re-submit. > 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done > it should be an easy rebase before submission. > 3. Wait for Andrew's WIP to be done, then submit with this update. > > > I'd like to avoid #3 because I don't know where this might fall on your > priorities list. If you are willing to do #1, that's certainly my preference. Rob
* Rob Herring <robh@kernel.org> [230226 17:22]: > On Thu, Feb 23, 2023 at 08:25:08AM -0800, Colin Foster wrote: > > On Thu, Feb 23, 2023 at 10:00:50AM -0600, Andrew Davis wrote: > > > On 2/22/23 2:38 PM, Colin Foster wrote: > > > > Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and > > > > the Phytec PCM-959 development kit. > > > > > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > > > --- > > > > > > > > v4 > > > > * New patch, based on a WIP from Andrew Davis <afd@ti.com> > > > > > > > > --- > > > > .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ > > > > 1 file changed, 29 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml > > > > > > How will this work if I add the same file? Why not take my WIP patch, make > > > the suggested changes from Rob, then have it as your first patch in this > > > series? > > > > Is your WIP intended to convert all omap.txt to ti,omap.yaml? Or chunk > > off devices one at a time? > > > > If the former, when your patch is done it should be a pretty simple > > rebase conflict resolution. If the latter (which feels more digestable) > > this offers that template. This was Rob's / Tony's suggestion, albeit > > before you sent your patch set. > > > > > > Anyway, I'm happy to do any of the following: > > > > 1. Take Andrew's patches, add these references and re-submit. > > 2. Keep this set as-is (with the typo fix) and when Andrew's WIP is done > > it should be an easy rebase before submission. > > 3. Wait for Andrew's WIP to be done, then submit with this update. > > > > > > I'd like to avoid #3 because I don't know where this might fall on your > > priorities list. > > If you are willing to do #1, that's certainly my preference. That would be great! Tony
diff --git a/Documentation/devicetree/bindings/arm/ti,omap.yaml b/Documentation/devicetree/bindings/arm/ti,omap.yaml new file mode 100644 index 000000000000..9c0e08f74fee --- /dev/null +++ b/Documentation/devicetree/bindings/arm/ti,omap.yaml @@ -0,0 +1,29 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/ti,omap.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments OMAP SoC architecture + +maintainers: + - Tony Lindgren <tony@atomide.com> + +description: + Platforms based on Texas Instruments OMAP SoC architecture. + +properties: + $nodename: + const: '/' + compatibnle: + oneOf: + + - description: TI OMAP 4460 SoC based platforms + items: + - enum: + - phytec,pcm049 # Phytec OMAP 4460 SoM + - phytec,pcm959 # Phytec development board for the pcm049 + - const: ti,omap4460 + - const: ti,omap4 + +additionalProperties: true
Add yaml documentation for TI OMAP devices for the Phytec PCM-049 SoM and the Phytec PCM-959 development kit. Signed-off-by: Colin Foster <colin.foster@in-advantage.com> --- v4 * New patch, based on a WIP from Andrew Davis <afd@ti.com> --- .../devicetree/bindings/arm/ti,omap.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/ti,omap.yaml