| Message ID | 20230307221732.3391-2-bage@debian.org |
|---|---|
| State | New |
| Headers | show |
| Series | Bluetooth: btrtl: add support for the RTL8723CS | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=727648 ---Test result--- Test Summary: CheckPatch PASS 2.00 seconds GitLint PASS 0.68 seconds SubjectPrefix PASS 0.25 seconds BuildKernel PASS 31.28 seconds CheckAllWarning PASS 34.68 seconds CheckSparse WARNING 39.08 seconds CheckSmatch WARNING 106.29 seconds BuildKernel32 PASS 30.42 seconds TestRunnerSetup PASS 442.73 seconds TestRunner_l2cap-tester PASS 16.49 seconds TestRunner_iso-tester PASS 17.64 seconds TestRunner_bnep-tester PASS 5.72 seconds TestRunner_mgmt-tester PASS 112.73 seconds TestRunner_rfcomm-tester PASS 9.10 seconds TestRunner_sco-tester PASS 8.38 seconds TestRunner_ioctl-tester PASS 9.78 seconds TestRunner_mesh-tester PASS 7.24 seconds TestRunner_smp-tester PASS 8.22 seconds TestRunner_userchan-tester PASS 6.12 seconds IncrementalBuild PASS 34.31 seconds Details ############################## Test: CheckSparse - WARNING Desc: Run sparse tool with linux kernel Output: net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:52:45: warning: array of flexible structures ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:52:45: warning: array of flexible structures --- Regards, Linux Bluetooth
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h index 400f8a7d0c3f..997107bfc0b1 100644 --- a/include/net/bluetooth/hci.h +++ b/include/net/bluetooth/hci.h @@ -294,6 +294,13 @@ enum { * during the hdev->setup vendor callback. */ HCI_QUIRK_BROKEN_MWS_TRANSPORT_CONFIG, + + /* When this quirk is set, max_page for local extended features + * is set to 1, even if controller reports higher number. Some + * controllers (e.g. RTL8723CS) report more pages, but they + * don't actually support features declared there. + */ + HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, }; /* HCI device flags */ diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index ad92a4be5851..8d8547fa9032 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -886,8 +886,13 @@ static u8 hci_cc_read_local_ext_features(struct hci_dev *hdev, void *data, if (rp->status) return rp->status; - if (hdev->max_page < rp->max_page) - hdev->max_page = rp->max_page; + if (hdev->max_page < rp->max_page) { + if (test_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, + &hdev->quirks)) + bt_dev_warn(hdev, "broken local ext features page 2"); + else + hdev->max_page = rp->max_page; + } if (rp->page < HCI_MAX_PAGES) memcpy(hdev->features[rp->page], rp->features, 8);