| Message ID | 20230312183622.460488-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 0d8d77228aa1efec69f92ef92e1cd9270c1151c4 |
| Headers | show |
| Series | [1/8] arm64: dts: qcom: sda660-inforce: correct key node name | expand |
Hi, On Sun, Mar 12, 2023 at 11:36 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > boards which use elan,ekth3000 with valid VCC: > > sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > index 850776c5323d..70d5a7aa8873 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > @@ -26,7 +26,7 @@ trackpad: trackpad@2c { > interrupt-parent = <&tlmm>; > interrupts = <58 IRQ_TYPE_EDGE_FALLING>; > > - vcc-supply = <&pp3300_fp_tp>; > + vdd-supply = <&pp3300_fp_tp>; Luckily it didn't matter since this regulator is always on, but good to have things described properly. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Quoting Krzysztof Kozlowski (2023-03-12 11:36:16) > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > Herobrine boards which use elan,ekth3000 with valid VCC: > > sc7280-herobrine-villager-r1-lte.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: ee2a62116015 ("arm64: dts: qcom: sc7280: Add device tree for herobrine villager") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Quoting Krzysztof Kozlowski (2023-03-12 11:36:17) > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > boards which use elan,ekth3000 with valid VCC: > > sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts index 7c81918eee66..7459525d9982 100644 --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts @@ -29,7 +29,7 @@ chosen { gpio-keys { compatible = "gpio-keys"; - volup { + key-volup { label = "Volume Up"; gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>; linux,code = <KEY_VOLUMEUP>;
gpio-key bindings expect children to be named with generic prefix: sda660-inforce-ifc6560.dtb: gpio-keys: 'volup' does not match any of the regexes: ... Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)