| Message ID | 20230324004040.572525-3-konrad.dybcio@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] mmc: msm_sdhci: Match clocks through "clocks" property | expand |
On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > In preparation for supporting upstream Linux device trees on Qualcomm > platforms, make this the default behavior. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > > drivers/serial/serial_msm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c > index 9c370cac323f..59a2cf27aaf1 100644 > --- a/drivers/serial/serial_msm.c > +++ b/drivers/serial/serial_msm.c > @@ -251,4 +251,5 @@ U_BOOT_DRIVER(serial_msm) = { > .priv_auto = sizeof(struct msm_serial_data), > .probe = msm_serial_probe, > .ops = &msm_serial_ops, > + .flags = DM_FLAG_PRE_RELOC, "u-boot,dm-pre-reloc" serves the same purpose but this looks even better as we would like the serial driver to be enabled by default prior to relocation. So you need to get rid of redundant "u-boot,dm-pre-reloc" from corresponding <platform>-uboot.dtsi files. -Sumit > }; > -- > 2.40.0 >
On 24.03.2023 07:04, Sumit Garg wrote: > On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> In preparation for supporting upstream Linux device trees on Qualcomm >> platforms, make this the default behavior. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> >> drivers/serial/serial_msm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c >> index 9c370cac323f..59a2cf27aaf1 100644 >> --- a/drivers/serial/serial_msm.c >> +++ b/drivers/serial/serial_msm.c >> @@ -251,4 +251,5 @@ U_BOOT_DRIVER(serial_msm) = { >> .priv_auto = sizeof(struct msm_serial_data), >> .probe = msm_serial_probe, >> .ops = &msm_serial_ops, >> + .flags = DM_FLAG_PRE_RELOC, > > "u-boot,dm-pre-reloc" serves the same purpose but this looks even > better as we would like the serial driver to be enabled by default > prior to relocation. Yep, this way you can take a dtb you built with Linux and use u-boot with that! So you need to get rid of redundant > "u-boot,dm-pre-reloc" from corresponding <platform>-uboot.dtsi files. Will do! Konrad > > -Sumit > >> }; >> -- >> 2.40.0 >>
diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index 9c370cac323f..59a2cf27aaf1 100644 --- a/drivers/serial/serial_msm.c +++ b/drivers/serial/serial_msm.c @@ -251,4 +251,5 @@ U_BOOT_DRIVER(serial_msm) = { .priv_auto = sizeof(struct msm_serial_data), .probe = msm_serial_probe, .ops = &msm_serial_ops, + .flags = DM_FLAG_PRE_RELOC, };
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/serial/serial_msm.c | 1 + 1 file changed, 1 insertion(+)