| Message ID | 20230320142103.3440-1-linmengbo0689@protonmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | leds: aw2013: Add vdd regulator | expand |
On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote: > On 20/03/2023 15:22, Lin, Meng-Bo wrote: > > Document vdd-supply, a regulator providing power to the "VDD" pin. > > > > No. This device does not have VDD pin. I checked in datasheet. I'm confused. This patch set much do something? I guess a better commit message would help. Let me request that. -- Lee Jones [李琼斯]
On 30/03/2023 13:46, Lee Jones wrote: > On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote: > >> On 20/03/2023 15:22, Lin, Meng-Bo wrote: >>> Document vdd-supply, a regulator providing power to the "VDD" pin. >>> >> >> No. This device does not have VDD pin. I checked in datasheet. > > I'm confused. This patch set much do something? > > I guess a better commit message would help. Let me request that. There was a v2 - with a discussion - so we wait for v3 which clearly indicates this is supply on controller side. IMHO, this is still wrong because it is controller's property, not device's, but Rob gave here green light, so v3 with proper explanation would be fine. Best regards, Krzysztof
On Thu, 30 Mar 2023, Krzysztof Kozlowski wrote: > On 30/03/2023 13:46, Lee Jones wrote: > > On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote: > > > >> On 20/03/2023 15:22, Lin, Meng-Bo wrote: > >>> Document vdd-supply, a regulator providing power to the "VDD" pin. > >>> > >> > >> No. This device does not have VDD pin. I checked in datasheet. > > > > I'm confused. This patch set much do something? > > > > I guess a better commit message would help. Let me request that. > > There was a v2 - with a discussion - so we wait for v3 which clearly > indicates this is supply on controller side. IMHO, this is still wrong > because it is controller's property, not device's, but Rob gave here > green light, so v3 with proper explanation would be fine. Understood, thanks. -- Lee Jones [李琼斯]
diff --git a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml index 08f3e1cfc1b1..51a58f4b8ed6 100644 --- a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml +++ b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml @@ -23,6 +23,9 @@ properties: vcc-supply: description: Regulator providing power to the "VCC" pin. + vdd-supply: + description: Regulator providing power to the "VDD" pin. + "#address-cells": const: 1
Document vdd-supply, a regulator providing power to the "VDD" pin. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- Documentation/devicetree/bindings/leds/leds-aw2013.yaml | 3 +++ 1 file changed, 3 insertions(+)