| Message ID | 20230407102324.42604-2-maarten.zanders@mind.be |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: lp55xx: configure internal charge pump | expand |
On Fri, Apr 07, 2023 at 12:23:23PM +0200, Maarten Zanders wrote: > Add a binding to configure the internal charge pump for lp55xx. > > Signed-off-by: Maarten Zanders <maarten.zanders@mind.be> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > Notes: > v1: implement as bool to disable charge pump > v2: rewrite to use string configuration, supporting all modes > v3: simplification by replacing string option by u8 constant, > removing previous Reviewed-by tags as it's a complete > rewrite of the patch. > v4: added notes > v5: dual license, change property type to u32 > v6: change license type for leds-lp-55xx.h to preferred tag > > .../devicetree/bindings/leds/leds-lp55xx.yaml | 8 ++++++++ > include/dt-bindings/leds/leds-lp55xx.h | 10 ++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 include/dt-bindings/leds/leds-lp55xx.h > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > index ae607911f1db..ede9cb9ca175 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > @@ -66,6 +66,12 @@ properties: > '#size-cells': > const: 0 > > + ti,charge-pump-mode: > + description: > + Set the operating mode of the internal charge pump as defined in > + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto. > + $ref: /schemas/types.yaml#/definitions/uint32 Needs constraints: default: 3 # Auto maximum: 3 > + > patternProperties: > '^multi-led@[0-8]$': > type: object > @@ -152,6 +158,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/leds/common.h> > + #include <dt-bindings/leds/leds-lp55xx.h> > > i2c { > #address-cells = <1>; > @@ -164,6 +171,7 @@ examples: > reg = <0x32>; > clock-mode = /bits/ 8 <2>; > pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */ > + ti,charge-pump-mode = <LP55XX_CP_BYPASS>; > > led@0 { > reg = <0>; > diff --git a/include/dt-bindings/leds/leds-lp55xx.h b/include/dt-bindings/leds/leds-lp55xx.h > new file mode 100644 > index 000000000000..a4fb4567715d > --- /dev/null > +++ b/include/dt-bindings/leds/leds-lp55xx.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +#ifndef _DT_BINDINGS_LEDS_LP55XX_H > +#define _DT_BINDINGS_LEDS_LP55XX_H > + > +#define LP55XX_CP_OFF 0 > +#define LP55XX_CP_BYPASS 1 > +#define LP55XX_CP_BOOST 2 > +#define LP55XX_CP_AUTO 3 > + > +#endif /* _DT_BINDINGS_LEDS_LP55XX_H */ > -- > 2.37.3 >
On Tue, 11 Apr 2023, Rob Herring wrote: > On Fri, Apr 07, 2023 at 12:23:23PM +0200, Maarten Zanders wrote: > > Add a binding to configure the internal charge pump for lp55xx. > > > > Signed-off-by: Maarten Zanders <maarten.zanders@mind.be> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > > > Notes: > > v1: implement as bool to disable charge pump > > v2: rewrite to use string configuration, supporting all modes > > v3: simplification by replacing string option by u8 constant, > > removing previous Reviewed-by tags as it's a complete > > rewrite of the patch. > > v4: added notes > > v5: dual license, change property type to u32 > > v6: change license type for leds-lp-55xx.h to preferred tag > > > > .../devicetree/bindings/leds/leds-lp55xx.yaml | 8 ++++++++ > > include/dt-bindings/leds/leds-lp55xx.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > create mode 100644 include/dt-bindings/leds/leds-lp55xx.h > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > index ae607911f1db..ede9cb9ca175 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > @@ -66,6 +66,12 @@ properties: > > '#size-cells': > > const: 0 > > > > + ti,charge-pump-mode: > > + description: > > + Set the operating mode of the internal charge pump as defined in > > + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Needs constraints: > > default: 3 # Auto > maximum: 3 Once this has been fixed, I'll apply both.
diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml index ae607911f1db..ede9cb9ca175 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml @@ -66,6 +66,12 @@ properties: '#size-cells': const: 0 + ti,charge-pump-mode: + description: + Set the operating mode of the internal charge pump as defined in + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto. + $ref: /schemas/types.yaml#/definitions/uint32 + patternProperties: '^multi-led@[0-8]$': type: object @@ -152,6 +158,7 @@ additionalProperties: false examples: - | #include <dt-bindings/leds/common.h> + #include <dt-bindings/leds/leds-lp55xx.h> i2c { #address-cells = <1>; @@ -164,6 +171,7 @@ examples: reg = <0x32>; clock-mode = /bits/ 8 <2>; pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */ + ti,charge-pump-mode = <LP55XX_CP_BYPASS>; led@0 { reg = <0>; diff --git a/include/dt-bindings/leds/leds-lp55xx.h b/include/dt-bindings/leds/leds-lp55xx.h new file mode 100644 index 000000000000..a4fb4567715d --- /dev/null +++ b/include/dt-bindings/leds/leds-lp55xx.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +#ifndef _DT_BINDINGS_LEDS_LP55XX_H +#define _DT_BINDINGS_LEDS_LP55XX_H + +#define LP55XX_CP_OFF 0 +#define LP55XX_CP_BYPASS 1 +#define LP55XX_CP_BOOST 2 +#define LP55XX_CP_AUTO 3 + +#endif /* _DT_BINDINGS_LEDS_LP55XX_H */